-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SearchGuard conf for Jaeger to ES image #1500
Add SearchGuard conf for Jaeger to ES image #1500
Conversation
Hi @pavolloffay. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @ewolinetz |
/ok-to-test |
lgtm @jcantrill can you confirm this is all thats required on our side? edit: asked for a change to restrict the index pattern |
/lgtm |
/hold |
@ewolinetz Just wanted to check the implications for multitenancy, to protect one tenants data from another. One approach is that the index prefix is specific to the tenant - as we would need to make sure the index patterns in SG supports that. However this assumes the Jaeger server is configured by something that controls the valid index prefix. Which maybe fine when used with Istio (service mesh), but not sure if Jaeger is configured for standalone usage outside of Istio. Are there any other ways that searchguard would need to be configured to ensure that the data from one tenant is protected from another? For example, if each tenant used a different client certificate, but possibly the same index prefix, would it be possible to still restrict access to the information generated by the separate tenants? |
No, because access is restricted based on the index and not something like the document type or field. Searchguard is capable of document and field level security but those are enterprise licensed features. Client certificates do not make a difference because SG resolves permissions to the index and the matches that to a user or group. Even if you declared separate roles and rolemappings the permissions will resolve to the same set of indices. |
3ed2150
to
c591495
Compare
/lgtm |
/retest |
1 similar comment
/retest |
ef3af20
to
f6283c3
Compare
can you squash your commits? |
Signed-off-by: Pavol Loffay <[email protected]>
9d34025
to
21b704c
Compare
@ewolinetz done |
/lgtm |
/hold cancel |
/retest |
@pavolloffay: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
https://jira.coreos.com/browse/LOG-327
Signed-off-by: Pavol Loffay [email protected]