Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-20395 replaced URLs in upstream section #6 in both the code a… #86946

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

…he code and comment below (configuring-dns-forwarding-with-tls.adoc)
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 13, 2025
@Miciah
Copy link
Contributor

Miciah commented Jan 15, 2025

nw-dns-forward.adoc might also need to be updated. However, I had some questions for the issue reporter on https://issues.redhat.com/browse/OCPBUGS-20395.

Copy link

openshift-ci bot commented Jan 24, 2025

@wgabor0427: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wgabor0427
Copy link
Contributor Author

wgabor0427 commented Jan 24, 2025

@Miciah I've updated the document based on option #2 in Will's comment of 1/17. I couldn't put a note in but I did add to the text in comment #6 in the doc. Let me know if this works. I haven't asked yet about nw-dns-forward.adoc. I wanted to get one file correct before I work on the other file. This edit is under the Configuring DNS forwarding with TLS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants