Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rel notes for storage 4.18 #86629

Open
wants to merge 1 commit into
base: enterprise-4.18
Choose a base branch
from

Conversation

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 30, 2024
@lpettyjo lpettyjo added branch/enterprise-4.18 peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 30, 2024
@lpettyjo lpettyjo added this to the Planned for 4.18 GA milestone Dec 30, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Dec 30, 2024

🤖 Wed Jan 01 19:41:10 - Prow CI generated the docs preview:

https://86629--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-18-release-notes.html

@lpettyjo lpettyjo requested a review from gnufied December 30, 2024 15:51
@lpettyjo lpettyjo force-pushed the rel_notes_4_18 branch 2 times, most recently from 82f709a to 49f2929 Compare December 30, 2024 18:16
@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 31, 2024
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nits -- Otherwise LGTM!!

release_notes/ocp-4-18-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-18-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-18-release-notes.adoc Outdated Show resolved Hide resolved
@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Dec 31, 2024
Copy link

openshift-ci bot commented Jan 1, 2025

@lpettyjo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@@ -821,6 +888,10 @@ In the following tables, features are marked with the following statuses:
[id="ocp-4-18-removed-features_{context}"]
=== Removed features

[id="ocp-4-18-removals-storage_{context}"]
==== The Shared Resource CSI Driver is removed
The Shared Resource CSI Driver feature is now removed from {product-title} 4.18. It was deprecated in {product-title} 4.17. This feature is now generally available in Builds for Red Hat OpenShift 1.1. To use this feature, ensure you are using Builds for Red Hat OpenShift 1.1 or later.
Copy link
Contributor

@Phaow Phaow Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Shared Resource CSI Driver feature is now removed from {product-title} 4.18. It was deprecated in {product-title} 4.17. This feature is now generally available in Builds for Red Hat OpenShift 1.1. To use this feature, ensure you are using Builds for Red Hat OpenShift 1.1 or later.
The Shared Resource CSI Driver feature was deprecated in {product-title} 4.17 and is now removed from {product-title} 4.18.

Maybe better.

==== Multiple vCenter support for vSphere CSI is generally available
{product-title} 4.17 introduced the ability to deploy {product-title} across multiple vSphere clusters (vCenters) as a Technology Preview feature. In {product-title} 4.18, Multiple vCenter support is now generally available.

For more information, see xref:../storage/container_storage_interface/persistent-storage-csi-vsphere.adoc#persistent-storage-csi-vsphere-multi-vcenter-support-overview_persistent-storage-csi-vsphere[Multiple vCenter support for vSphere CSI] and xref:../installing/installing_vsphere/installation-config-parameters-vsphere.adoc[Installation configuration parameters for vSphere].

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not the scope of this RN PR, but let's ensure we update the reference Multiple vCenter support for vSphere CSI to remove the TP.

For more information, see xref:../storage/persistent_storage/persistent_storage_local/persistent-storage-local.adoc#local-removing-device_persistent-storage-local[Removing a local volume or local volume set].

[id="ocp-4-18-release-notes-storage-volume-group-snapshots_{context}"]
==== CSI volume group snapshots is generally available

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good, but please note the code is still not ready now and we need to recheck this part before release.

For more information, see xref:../storage/container_storage_interface/persistent-storage-csi-smb-cifs.adoc#persistent-storage-csi-smb-cifs[CIFS/SMB CSI Driver Operator].

[id="ocp-4-18-release-notes-storage-secret-csi-driver_{context}"]
==== Secret Store CSI Driver Operator is generally available

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good to me for Secret Store part.
Double confirm "to mount multiple secrets, keys, and certificates stored" => "to mount multiple secrets, keys and certificates stored" would be better?


[id="ocp-4-18-release-notes-storage-pv-last-phase-transition-time_{context}"]
==== Persistent volume last phase transition time parameter is generally available
{product-title} 4.16 introduced a new parameter, `LastPhaseTransitionTime`, which has a timestamp that is updated every time a persistent volume (PV) transitions to a different phase (`pv.Status.Phase`). For {product-title} 4.18, this feature is generally available.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content LGTM

==== Persistent volume last phase transition time parameter is generally available
{product-title} 4.16 introduced a new parameter, `LastPhaseTransitionTime`, which has a timestamp that is updated every time a persistent volume (PV) transitions to a different phase (`pv.Status.Phase`). For {product-title} 4.18, this feature is generally available.

For more information about using the persistent volume last phase transition time parameter, see xref:../storage/understanding-persistent-storage.adoc#persistent-volumes_understanding-persistent-storage[Persistent volumes].
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reference takes to PV docs, but doesn't have details about "last phase transition time parameter"

==== Always apply persistent volume reclaim policy (Technical Preview)
Prior to {product-title} 4.18, the persistent volume (PV) reclaim policy was not always honored.

For a bound PV-persistent volume claim (PVC) pair, the ordering of PV-PVC deletion determined whether the PV delete reclaim policy was applied or not. The PV applied the reclaim policy if the PVC was deleted prior to deleting the PV. However, if the PV was deleted prior to deleting the PVC, then the reclaim policy was not applied. As a result of that behavior, the associated storage asset in the external infrastructure was not removed.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For a bound PV-persistent volume claim (PVC) pair, the ordering of PV-PVC deletion determined whether the PV delete reclaim policy was applied or not. The PV applied the reclaim policy if the PVC was deleted prior to deleting the PV. However, if the PV was deleted prior to deleting the PVC, then the reclaim policy was not applied. As a result of that behavior, the associated storage asset in the external infrastructure was not removed.
For a bound persistent volume (PV)-persistent volume claim (PVC) pair, the ordering of PV-PVC deletion determined whether the PV delete reclaim policy was applied or not. The PV applied the reclaim policy if the PVC was deleted prior to deleting the PV. However, if the PV was deleted prior to deleting the PVC, then the reclaim policy was not applied. As a result of that behavior, the associated storage asset in the external infrastructure was not removed.

For more information, see xref:../storage/container_storage_interface/persistent-storage-csi-vsphere.adoc#persistent-storage-csi-vsphere-multi-vcenter-support-overview_persistent-storage-csi-vsphere[Multiple vCenter support for vSphere CSI] and xref:../installing/installing_vsphere/installation-config-parameters-vsphere.adoc[Installation configuration parameters for vSphere].

[id="ocp-4-18-release-notes-storage-always-honor-reclaim-policy_{context}"]
==== Always apply persistent volume reclaim policy (Technical Preview)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
==== Always apply persistent volume reclaim policy (Technical Preview)
==== Always honor persistent volume reclaim policy (Technical Preview)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case to keep title consistent with Upstream feature


For a bound PV-persistent volume claim (PVC) pair, the ordering of PV-PVC deletion determined whether the PV delete reclaim policy was applied or not. The PV applied the reclaim policy if the PVC was deleted prior to deleting the PV. However, if the PV was deleted prior to deleting the PVC, then the reclaim policy was not applied. As a result of that behavior, the associated storage asset in the external infrastructure was not removed.

With {product-title} 4.18, the PV reclaim policy is consistently always applied. This feature has Technical Preview status.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have this feature listed under "Storage TechPreview features" table? cc. @duanwei33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants