-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update builds-restricting-build-strategy-globally.adoc #86625
base: main
Are you sure you want to change the base?
Conversation
Removed the pre-requisite as that was not required.
Hi @amrin101. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test ...but I'm not qualified to review/approve. |
🤖 Thu Jan 02 14:23:52 - Prow CI generated the docs preview: |
@amrin101: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label peer-review-needed |
@amrin101: Can not set label peer-review-needed: Must be member in one of these teams: [team-red-hat] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bergerhoffer Can you please help shepherd this PR through? I don't know how this repo works, and don't have the power to do anything in it anyway :) |
Hi @amrin101, I've updated the description to include 4.17 and newer (so this includes 4.18 as well). I'll add send it it for peer review, but we'll also need to get QE approval before we could merge. Let me look into who might be a good reviewer for this. /label peer-review-needed |
@amrin101 Should this update apply to all currently supported versions, or only 4.17 and later? |
I pinged the control plane QEs to see if someone can help us QE review this. |
/label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Still needs QE review.
/label peer-review-done |
Hello There, I can see the label is ok-to-test, so kindly please may I know where it is stuck so that I can do the required changes. Regards, |
Removed the pre-requisite as that was not required.
. Incorrect Pre-requisite steps for restricting users to access to a build strategyVersion(s):
4.17+Issue:
https://issues.redhat.com/browse/OSDOCS-13018
Link to docs preview:
https://86625--ocpdocs-pr.netlify.app/openshift-enterprise/latest/cicd/builds/securing-builds-by-strategy.html#builds-restricting-build-strategy-globally_securing-builds-by-strategy
QE review:
Additional information: