Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update builds-restricting-build-strategy-globally.adoc #86625

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amrin101
Copy link

@amrin101 amrin101 commented Dec 30, 2024

Removed the pre-requisite as that was not required.

. Incorrect Pre-requisite steps for restricting users to access to a build strategy

Version(s):

4.17+

Issue:

https://issues.redhat.com/browse/OSDOCS-13018

Link to docs preview:
https://86625--ocpdocs-pr.netlify.app/openshift-enterprise/latest/cicd/builds/securing-builds-by-strategy.html#builds-restricting-build-strategy-globally_securing-builds-by-strategy

QE review:

  • QE has approved this change.

Additional information:

Removed the pre-requisite as that was not required.
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 30, 2024
Copy link

openshift-ci bot commented Dec 30, 2024

Hi @amrin101. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@2uasimojo
Copy link
Member

/ok-to-test

...but I'm not qualified to review/approve.

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2025
@ocpdocs-previewbot
Copy link

🤖 Thu Jan 02 14:23:52 - Prow CI generated the docs preview:

https://86625--ocpdocs-pr.netlify.app/openshift-enterprise/latest/cicd/builds/securing-builds-by-strategy.html

Copy link

openshift-ci bot commented Jan 2, 2025

@amrin101: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@amrin101
Copy link
Author

amrin101 commented Jan 3, 2025

/label peer-review-needed

Copy link

openshift-ci bot commented Jan 3, 2025

@amrin101: Can not set label peer-review-needed: Must be member in one of these teams: [team-red-hat]

In response to this:

/label peer-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@2uasimojo
Copy link
Member

@bergerhoffer Can you please help shepherd this PR through? I don't know how this repo works, and don't have the power to do anything in it anyway :)

@bergerhoffer
Copy link
Contributor

Hi @amrin101, I've updated the description to include 4.17 and newer (so this includes 4.18 as well).

I'll add send it it for peer review, but we'll also need to get QE approval before we could merge. Let me look into who might be a good reviewer for this.

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 7, 2025
@bergerhoffer bergerhoffer added this to the Continuous Release milestone Jan 7, 2025
@bergerhoffer
Copy link
Contributor

@amrin101 Should this update apply to all currently supported versions, or only 4.17 and later?

@bergerhoffer
Copy link
Contributor

I pinged the control plane QEs to see if someone can help us QE review this.

@cbippley
Copy link
Contributor

cbippley commented Jan 7, 2025

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 7, 2025
Copy link
Contributor

@cbippley cbippley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Still needs QE review.

@cbippley
Copy link
Contributor

cbippley commented Jan 7, 2025

/label peer-review-done
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 7, 2025
@amrin101
Copy link
Author

Hello There,

I can see the label is ok-to-test, so kindly please may I know where it is stuck so that I can do the required changes.

Regards,
Amrin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.17 branch/enterprise-4.18 ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants