-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-12890 and 12891#GCP PD support for C3 and N4 instance types #86517
base: main
Are you sure you want to change the base?
Conversation
modules/persistent-storage-csi-gcp-hyperdisk-create-sc-during-install.adoc
Outdated
Show resolved
Hide resolved
655d49d
to
d59c8ba
Compare
/label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/label peer-review-done |
@lpettyjo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
||
* A GCP cluster with n4-standard-2 or n4-standard-4 nodes can erroneously exceed the maximum attachable disk number, which should be 16. | ||
|
||
* The default storage class is standard-csi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should rewrite this to point to the section "Creating the storage class for C3 and N4 instance types"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the best I can there. We have some limitations regarding xrefs in our tool.
|
||
* Hyperdisk-balanced disks with RWX is not supported. | ||
|
||
* Storage pool cloning is not supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cloning volumes is not supported when using storage pools
|
||
* The default storage class is standard-csi. | ||
|
||
* Clusters with mixed virtual machines (VMs) that use different storage types, for example, N2 and N4, are not supported. This is due to hyperdisks-balanced disks not being usable on most legacy VMs. Similarly, regular persistent disks are not usable on N4/C4 VMs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we mean C3 instead of C4?
= C3 and N4 instance type limitations | ||
The GCP PD CSI driver support for the C3 instance type for bare metal and N4 machine series have the following limitations: | ||
|
||
* Hyperdisk-balanced disks with RWX is not supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this indeed does not work but google is planning to fix the bug and we plan to add a fix in 4.18.z.
Should we say that there is a known issue instead of not supported?
[id="persistent-storage-csi-gcp-hyperdisk-storage-pools_{context}"] | ||
= Storage pools for hyperdisk-balanced disks | ||
|
||
Hyperdisk storage pools can be used with Compute Engine for large-scale storage. A hyperdisk storage pool is a purchased collection of capacity, throughput, and IOPS, which you can then provision for your applications as needed. You can use hyperdisk storage pools to create and manage disks in pools and use the disks across multiple workloads. By managing disks in aggregate, you can save costs while achieving expected capacity and performance growth. By using only the storage that you need in hyperdisk storage pools, you reduce the complexity of forecasting capacity and reduce management by going from managing hundreds of disks to managing a single storage pool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version(s): 4.18+
Issue: https://issues.redhat.com/browse/OSDOCS-12890 and https://issues.redhat.com/browse/OSDOCS-12891
Link to docs preview: https://86517--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/container_storage_interface/persistent-storage-csi-gcp-pd.html#c3-instance-type-for-bare-metal-and-n4-machine-series
QE review:
Additional information:
PTAL: @gcharot @jsafrane @chao007 @dfajmon