Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enterprise-4.17] CNV#40185: RN shell file 4.17 #79779

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[enterprise-4.17] CNV#40185: RN shell file 4.17 #79779

merged 1 commit into from
Aug 1, 2024

Conversation

danielclowers
Copy link
Contributor

@danielclowers danielclowers commented Jul 31, 2024 •
edited
Loading

Version(s):
4.17

Issue:
https://issues.redhat.com/browse/CNV-40185

Link to docs preview:
https://79779--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-17-release-notes.html

QE review:
NA

Additional information:

Updated release notes file name and anchor IDs
Removed New and changed features content
Removed Bug fixes content
Removed Removed features content
Added CNV-38594 to Known Issues -> Web Console
Added CNV-22314 to Tech Preview

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 31, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 31, 2024 •
edited
Loading

🤖 Wed Jul 31 17:46:50 - Prow CI generated the docs preview:

https://79779--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-17-release-notes.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 31, 2024

@danielclowers: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danielclowers
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 31, 2024
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 31, 2024
@lpettyjo lpettyjo self-requested a review July 31, 2024 18:12
@lpettyjo lpettyjo added this to the Planned for 4.17 GA milestone Jul 31, 2024
lpettyjo
lpettyjo reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 31, 2024
@danielclowers
Copy link
Contributor Author

/label merge-review-needed

@sjhala-ccs sjhala-ccs added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 1, 2024
@jldohmann jldohmann added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 1, 2024
jldohmann
jldohmann approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@jldohmann jldohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jldohmann jldohmann merged commit 007d403 into openshift:enterprise-4.17 Aug 1, 2024
2 checks passed
@jldohmann jldohmann removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpettyjo lpettyjo lpettyjo left review comments

@jldohmann jldohmann jldohmann approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.17 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.17 GA
Development

Successfully merging this pull request may close these issues.
5 participants
@danielclowers @ocpdocs-previewbot @jldohmann @lpettyjo @sjhala-ccs