Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBSDOCS-890: Fix bugs in syslog docs #73478

Merged
merged 1 commit into from
Apr 3, 2024
Merged

OBSDOCS-890: Fix bugs in syslog docs #73478

merged 1 commit into from
Apr 3, 2024

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Mar 20, 2024 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2024 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references OBSDOCS-890 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.13+ (logging 5.9+)

Issue:
https://issues.redhat.com/browse/OBSDOCS-890

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abrennan89 abrennan89 added this to the Continuous Release milestone Mar 20, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2024
@abrennan89 abrennan89 added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 20, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 20, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 20, 2024 •
edited
Loading

🤖 Wed Apr 03 14:51:47 - Prow CI generated the docs preview:

https://73478--ocpdocs-pr.netlify.app/

@abrennan89 abrennan89 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 21, 2024 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references OBSDOCS-890 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.13+ (logging 5.9+)

Issue:
https://issues.redhat.com/browse/OBSDOCS-890

Link to docs preview:
https://73478--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/log_collection_forwarding/cluster-logging-collector#log-collector-rsyslog-server_cluster-logging-collector

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2024
@abrennan89 abrennan89 changed the title [WIP] OBSDOCS-890: Fix bugs in syslog docs OBSDOCS-890: Fix bugs in syslog docs Mar 21, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2024
@abrennan89
Copy link
Contributor Author

PR needs to be rebased once #73567 merges
/hold

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2024 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references OBSDOCS-890 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.13+ (logging 5.9+)

Issue:
https://issues.redhat.com/browse/OBSDOCS-890

Link to docs preview:
https://73478--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/log_collection_forwarding/cluster-logging-collector#cluster-logging-collector-input-receivers

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abrennan89
Copy link
Contributor Author

/retest

@abrennan89 abrennan89 requested a review from r2d2rnd March 27, 2024 17:36
@abrennan89 abrennan89 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2024
@abrennan89 abrennan89 force-pushed the OBSDOCS-890 branch 2 times, most recently from 8e7a4e5 to 314661d Compare April 2, 2024 15:48
@abrennan89
Copy link
Contributor Author

/retest

@abrennan89 abrennan89 added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 2, 2024
@cbippley
Copy link
Contributor

cbippley commented Apr 2, 2024

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 2, 2024
cbippley
cbippley reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@cbippley cbippley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cbippley
Copy link
Contributor

cbippley commented Apr 2, 2024 •
edited
Loading

/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Apr 2, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 2, 2024

@cbippley: Those labels are not set on the issue: peer-review-needed

In response to this:

/label peer-review-done
/remove-label peer-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cbippley
Copy link
Contributor

cbippley commented Apr 2, 2024

/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 2, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 3, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 3, 2024

@abrennan89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abrennan89 abrennan89 merged commit 0d44eea into openshift:main Apr 3, 2024
2 checks passed
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.13

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.14

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.15

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #74143

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 3, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #74144

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #74145

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 3, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #74146

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 deleted the OBSDOCS-890 branch July 2, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbippley cbippley cbippley left review comments

@jcantrill jcantrill jcantrill left review comments

@r2d2rnd r2d2rnd Awaiting requested review from r2d2rnd

Assignees

@anpingli anpingli

Labels
branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
7 participants
@abrennan89 @openshift-ci-robot @ocpdocs-previewbot @anpingli @cbippley @openshift-cherrypick-robot @jcantrill