Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDOCS-9949: Removed an egress section from the ROSA docs #72991

Merged

Conversation

EricPonvelle
Copy link
Contributor

Version(s):
enterprise-4.15+

Issue:
OSDOCS-9949

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Conditioned out "Considerations for using an egress IP on additional network interfaces" from ROSA docs

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2024

@EricPonvelle: This pull request references OSDOCS-9949 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
enterprise-4.15+

Issue:
OSDOCS-9949

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
Conditioned out "Considerations for using an egress IP on additional network interfaces" from ROSA docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2024
@ocpdocs-previewbot
Copy link

🤖 Tue Mar 12 14:51:23 - Prow CI generated the docs preview:
https://72991--ocpdocs-pr.netlify.app

Copy link

openshift-ci bot commented Mar 12, 2024

@EricPonvelle: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kumuduh
Copy link

kumuduh commented Mar 12, 2024

Reviewed. /lgtm

@EricPonvelle EricPonvelle added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2024
@EricPonvelle EricPonvelle merged commit b53af2c into openshift:main Mar 12, 2024
2 checks passed
@EricPonvelle
Copy link
Contributor Author

/cherrypick enterprise-4.15

@EricPonvelle
Copy link
Contributor Author

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #73015

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #73016

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants