Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDOCS#6927: Italicized Let's Encrypt #62507

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

xenolinux
Copy link
Contributor

@xenolinux xenolinux commented Jul 18, 2023

Version(s): 4.13+

Issue: https://issues.redhat.com/browse/OSDOCS-6927

Link to docs preview: https://62507--docspreview.netlify.app/openshift-enterprise/latest/security/cert_manager_operator/cert-manager-operator-issuer-acme.html#cert-manager-acme-about_cert-manager-operator-issuer-acme

QE review: This is a follow-up PR to make the "Let's Encrypt" term Italicized. This PR doesn't add any technical changes. QE approval is present in the original/merged PR.

  • QE has approved this change.

Additional information: #59702 (comment)

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 18, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 18, 2023

🤖 Updated build preview is available at:
https://62507--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/20090

@xenolinux
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 19, 2023
@ShaunaDiaz
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jul 19, 2023
@ShaunaDiaz
Copy link
Contributor

@xenolinux
https://62507--docspreview.netlify.app/openshift-enterprise/latest/security/cert_manager_operator/cert-manager-operator-issuer-acme.html#cert-manager-acme-http01_cert-manager-operator-issuer-acme has an unitalicized "Let's Encrypt" in the second sentence.
The "1. Create an ACME cluster issuer" example yaml has an unitalicized "Let's Encrypt" in bullet #3.
I didn't see any others, but you might want to search the repo in your editor just to be sure everything is marked italics and rendering OK.

@ShaunaDiaz
Copy link
Contributor

@maxwelldb Will you please verify my peer review? Thank you!

@ShaunaDiaz
Copy link
Contributor

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 19, 2023
@xenolinux
Copy link
Contributor Author

@xenolinux https://62507--docspreview.netlify.app/openshift-enterprise/latest/security/cert_manager_operator/cert-manager-operator-issuer-acme.html#cert-manager-acme-http01_cert-manager-operator-issuer-acme has an unitalicized "Let's Encrypt" in the second sentence. The "1. Create an ACME cluster issuer" example yaml has an unitalicized "Let's Encrypt" in bullet #3. I didn't see any others, but you might want to search the repo in your editor just to be sure everything is marked italics and rendering OK.

Done. Updated the PR!

@xenolinux
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 19, 2023
@maxwelldb
Copy link
Contributor

@maxwelldb Will you please verify my peer review? Thank you!

@ShaunaDiaz I think your review is fair.

I'm not sure if "Let's Encrypt" needs to be italicized to begin with. I think not. Mixing styles is obviously worse than the alternative, though.

Per https://www.ibm.com/docs/en/ibm-style?topic=format-highlighting, seems to me that all instances of _Let's Encrypt_ should be Let's Encrypt.

Copy link
Contributor

@maxwelldb maxwelldb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking a review on this for posterity's sake.

@skrthomas skrthomas added this to the Continuous Release milestone Jul 19, 2023
@skrthomas skrthomas added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 19, 2023
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge review lgtm

@skrthomas skrthomas merged commit 8efeb00 into openshift:main Jul 19, 2023
@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.13

@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@skrthomas: new pull request created: #62583

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@skrthomas: new pull request created: #62584

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.13 branch/enterprise-4.14 merge-review-in-progress Signifies that the merge review team is reviewing this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants