-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS#6927: Italicized Let's Encrypt #62507
Conversation
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/20090 |
/label peer-review-needed |
/label peer-review-in-progress |
@xenolinux |
@maxwelldb Will you please verify my peer review? Thank you! |
/remove-label peer-review-needed |
Done. Updated the PR! |
/label merge-review-needed |
@ShaunaDiaz I think your review is fair. I'm not sure if "Let's Encrypt" needs to be italicized to begin with. I think not. Mixing styles is obviously worse than the alternative, though. Per https://www.ibm.com/docs/en/ibm-style?topic=format-highlighting, seems to me that all instances of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking a review on this for posterity's sake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge review lgtm
/cherrypick enterprise-4.13 |
/cherrypick enterprise-4.14 |
@skrthomas: new pull request created: #62583 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@skrthomas: new pull request created: #62584 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s): 4.13+
Issue: https://issues.redhat.com/browse/OSDOCS-6927
Link to docs preview: https://62507--docspreview.netlify.app/openshift-enterprise/latest/security/cert_manager_operator/cert-manager-operator-issuer-acme.html#cert-manager-acme-about_cert-manager-operator-issuer-acme
QE review: This is a follow-up PR to make the "Let's Encrypt" term Italicized. This PR doesn't add any technical changes. QE approval is present in the original/merged PR.
Additional information: #59702 (comment)