Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSM-3796: Refactor adding services to a mesh #59177

Merged
merged 1 commit into from
May 25, 2023
Merged

OSSM-3796: Refactor adding services to a mesh #59177

merged 1 commit into from
May 25, 2023

Conversation

rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Apr 21, 2023 •
edited
Loading

Version(s): 4.10+

Issue: https://issues.redhat.com/browse/OSSM-3796

Link to docs preview: https://59177--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-create-mesh.html

QE review:

  • QE has approved this change.

Additional information:

Dev Review: Marko
QA Review: Francisco
Peer Review: Rolfe

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 21, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 21, 2023 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OSSM-3796 which is a valid jira issue.

In response to this:

Version(s):

Issue: https://issues.redhat.com/browse/OSSM-3796

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 21, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 21, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://59177--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/16698

@rh-tokeefe rh-tokeefe force-pushed the OSSM-3796A branch 2 times, most recently from 95c5e4f to 75f666d Compare April 24, 2023 11:10
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 25, 2023 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OSSM-3796 which is a valid jira issue.

In response to this:

Version(s): 4.10+

Issue: https://issues.redhat.com/browse/OSSM-3796

Link to docs preview: https://59177--docspreview.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-create-mesh.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rh-tokeefe rh-tokeefe changed the title OSSM-3796: Refactor adding services to a mesh [WIP] OSSM-3796: Refactor adding services to a mesh Apr 25, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2023
@rh-tokeefe rh-tokeefe force-pushed the OSSM-3796A branch 4 times, most recently from 93dc9e9 to b4573db Compare April 26, 2023 16:38
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 26, 2023
@rh-tokeefe rh-tokeefe force-pushed the OSSM-3796A branch 8 times, most recently from f9499e6 to 579074c Compare May 2, 2023 19:52
@abrennan89 abrennan89 added this to the Continuous Release milestone May 24, 2023
@bburt-rh bburt-rh added peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR labels May 25, 2023
@rh-tokeefe rh-tokeefe force-pushed the OSSM-3796A branch 2 times, most recently from 9662a7b to 38881cc Compare May 25, 2023 13:32
@bburt-rh bburt-rh merged commit ee63c1e into openshift:main May 25, 2023
@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.10

@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.11

@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.12

@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.13

@bburt-rh
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 25, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #60560

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 25, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #60561

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 25, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #60562

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 25, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #60563

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 25, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bburt-rh: new pull request created: #60564

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bburt-rh bburt-rh bburt-rh left review comments

@fjglira fjglira fjglira left review comments

@luksa luksa luksa left review comments

@rolfedh rolfedh rolfedh approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
9 participants
@rh-tokeefe @openshift-ci-robot @ocpdocs-previewbot @bburt-rh @openshift-cherrypick-robot @rolfedh @luksa @fjglira @abrennan89