Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layering: Use rhel-coreos now #58486

Closed
wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Member

@cgwalters
Copy link
Member Author

/assign @mburke5678

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 10, 2023
@ocpdocs-previewbot
Copy link

@mburke5678
Copy link
Contributor

@cgwalters This applies to 4.12 only??

@cgwalters
Copy link
Member Author

To 4.13+

@mburke5678
Copy link
Contributor

@cgwalters For 4.12, use rhel-coreos-8. For 4.13+, use rhel-coreos-9?

@cgwalters
Copy link
Member Author

For 4.13+ it's just rhel-coreos. Sorry, I should have linked to openshift/machine-config-operator#3596 instead.

@mburke5678
Copy link
Contributor

In that case, I am thinking that the 4.12 docs are correct. Is so, the In {product-title} 4.12, use rhel-coreos-8 instead of rhel-coreos sentence in this PR isn't needed if we apply this PR to 4.13+. Am I mistaken?

@cgwalters
Copy link
Member Author

In that case, I am thinking that the 4.12 docs are correct. Is so, the In {product-title} 4.12, use rhel-coreos-8 instead of rhel-coreos sentence in this PR isn't needed if we apply this PR to 4.13+. Am I mistaken?

Yeah; I just know I've commonly looked at newer versions of the docs when trying to operate on older versions of OCP.

But I'm fine removing it if you prefer too. (Feel free to force-push any updates you want to this PR too!)

@mburke5678
Copy link
Contributor

Allow me, if you don't mind to PTAL: #58561

@cgwalters
Copy link
Member Author

Closing in favor of #58561

@cgwalters cgwalters closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants