Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ2007783 - Updating ssh key in installer #45034

Merged

Conversation

kelbrown20
Copy link
Contributor

@kelbrown20 kelbrown20 commented Apr 27, 2022

For versions 4.8+
Bugzilla

Ready for QA

Preview: Generating a key pair for cluster node SSH access

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 27, 2022
@netlify
Copy link

netlify bot commented Apr 27, 2022

Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit 265f7ec
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/627d2e92ee96a10008ba09ee
😎 Deploy Preview https://deploy-preview-45034--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kelbrown20
Copy link
Contributor Author

@MayXuQQ @tsze-redhat Please let me know if there needs to be any more updates for this bug, thank you!

@MayXuQQ
Copy link

MayXuQQ commented Apr 27, 2022

@kelbrown20
Copy link
Contributor Author

It seems like the oc does not need to be changed based on the context of the procedure. Is this accurate?

@MayXuQQ
Copy link

MayXuQQ commented Apr 27, 2022

It seems like the oc does not need to be changed based on the context of the procedure. Is this accurate?

@tsze-redhat , @kelbrown20 if not put the oc / openshift-install in $PATH, suggest use ./oc ./openshift-install

@kelbrown20
Copy link
Contributor Author

@MayXuQQ Hi May! To got back to me and said that it's ok to leave out the ./oc change. Just another quick question, is the rsa the recommended key standard to use? I wasn't sure if it was recommended too use, ed25519. Thank you!

@MayXuQQ
Copy link

MayXuQQ commented May 11, 2022

ed25519 is prefer ,
id_ed25519 is the private file, id_ed25519.pub is the public file.

@kelbrown20
Copy link
Contributor Author

@MayXuQQ Gotcha! If that is the case, then the change in this PR should no longer be needed. Do you think it would be best too close this PR and BZ since all of the issues are resolved?

@MayXuQQ
Copy link

MayXuQQ commented May 12, 2022

checking the bug , need replace id_rsa.pub to id_ed25519.pub
3
https://docs.openshift.com/container-platform/4.8/installing/installing_azure/installing-azure-user-infra.html#ssh-agent-using_installing-azure-user-infra

We give example of
ssh-keygen -t ed25519 -N '' -f /<file_name>

but later on, we show results of
cat ~/.ssh/id_rsa.pub

@kelbrown20 kelbrown20 force-pushed the fixing-example-for-installer-2007783 branch from b49113a to b75566d Compare May 12, 2022 12:59
@kelbrown20
Copy link
Contributor Author

Acked, just updated. Thank you!

@MayXuQQ
Copy link

MayXuQQ commented May 12, 2022

  1. Add your SSH private key to the ssh-agent
    Specify the path and file name for your SSH private key, such as ~/.ssh/id_ed25519

@kelbrown20 kelbrown20 force-pushed the fixing-example-for-installer-2007783 branch from b75566d to 265f7ec Compare May 12, 2022 15:58
@kelbrown20
Copy link
Contributor Author

Good catch! Just fixed

@MayXuQQ
Copy link

MayXuQQ commented May 12, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2022
Copy link
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.8

@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.9

@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.10

@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #45678

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #45679

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #45680

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #45681

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants