Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated URL #4455

Merged
merged 1 commit into from
May 23, 2017
Merged

Updated URL #4455

merged 1 commit into from
May 23, 2017

Conversation

ahardin-rh
Copy link
Contributor

@ahardin-rh ahardin-rh commented May 22, 2017

Addresses #4454

@ahardin-rh
Copy link
Contributor Author

ahardin-rh commented May 22, 2017

@siamaksade @tiwillia PTAL

@tiwillia
Copy link
Member

@ahardin-rh We might just not want to include a link here. There are several free-tier clusters, meaning there are several internal registries. The one linked is just one of those.

@ahardin-rh
Copy link
Contributor Author

@tiwillia Thanks! Updated with a replaceable instead.

@tiwillia
Copy link
Member

@ahardin-rh help me out here, whats a replaceable? Do we have a way to replace it with the right URL depending on which cluster the user is a part of?

@ahardin-rh
Copy link
Contributor Author

@tiwillia The example is just updated to not be specific (<registry_URL>), since the path can change. Would the user already know the URL, or would they have to look it up somewhere? If they have to look it up, we can provide guidance here as to how they can do that.

@siamaksade
Copy link

@ahardin-rh I don't know of any other way to retrieve the registry URL. Users don't have access to list routes in the default namespace. It might actually make sense to have it somewhere within the web console on e.g. About page.

Alternatively if registry URLs follow a pattern across online clusters, we could specify the pattern: registry.<plan>-<region>.openshift.com

We can document then that the <plan>-<region> is the same as the one they see in the master URL.

@tiwillia
Copy link
Member

@abhgupta and I yesterday discussed the possibility of adding this URL into the console About page, as mentioned above. The current plan is to add the URL there: https://trello.com/c/zztJk7Lk/787-2-add-registry-url-in-about-cli-page-in-console

Perhaps we can hold off on setting the URL in the docs and instead document the existence of the URL in the console, once its ready?

@abhgupta
Copy link
Member

abhgupta commented May 23, 2017

@ahardin-rh @timothyh @siamaksade Here are my thoughts.

  1. Add a link to the registry URL on the console "About" or "Command Line Tools" page
  2. Add documentation to provide the URL format for the registry (with a replaceable for cluster ID) --> registry.<clusterID>.openshift.com
  3. Perhaps, in the docs, provide a list of cluster region names to cluster ID mappings (eg: Starter US East 1 --> starter-us-east-1)

On point 3, the introduction of new free/paid tier clusters is not something that happens overnight. So, the docs team should be able to keep this section updated, if they choose to maintain the mapping in the docs.

@tiwillia
Copy link
Member

@abhgupta that sounds great. We can probably move this PR to complete # 2 in your list for now.

@ahardin-rh
Copy link
Contributor Author

ahardin-rh commented May 23, 2017

@tiwillia @abhgupta @siamaksade Thanks! I updated the PR, satisfying # 2 on @abhgupta's list.

Point # 3 Is something worth discussing with @aheslin

@tiwillia
Copy link
Member

LGTM 👍

@ahardin-rh ahardin-rh merged commit 61de034 into openshift:master May 23, 2017
@ahardin-rh
Copy link
Contributor Author

No revision history needed

@bfallonf bfallonf modified the milestones: Next Release, Staging, Published 05/25/2017 May 24, 2017
@bfallonf bfallonf removed this from the Staging milestone May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants