Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick start updates, Example updates, and Updates to SBO topics for modular-docs template and content type attributes alignment #41809

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Quick start updates, Example updates, and Updates to SBO topics for modular-docs template and content type attributes alignment #41809

merged 1 commit into from
Feb 22, 2022

Conversation

Srivaralakshmi
Copy link
Contributor

@Srivaralakshmi Srivaralakshmi commented Feb 13, 2022 •
edited
Loading

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 13, 2022
@netlify
Copy link

netlify bot commented Feb 13, 2022 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 2fd1d2a

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/62150e69c229d90008184f18

😎 Browse the preview: https://deploy-preview-41809--osdocs.netlify.app

@Srivaralakshmi
Copy link
Contributor Author

@pmacik, @dperaza4dustbit, and @baijum: PTAL at the PR and provide your feedback. Thanks!

Note to peer reviewers - Please review the following topic files to review updates for modular-docs template and content type attributes alignment:

  • sbo-unbinding-workloads-from-a-backing-service.adoc
  • sbo-rbac-requirements.adoc
  • sbo-naming-strategies.adoc
  • sbo-methods-of-exposing-binding-data.adoc
  • sbo-data-model.adoc
  • sbo-categories-of-exposable-binding-data.adoc
  • sbo-binding-workloads-that-are-not-compliant-with-PodSpec.adoc
  • sbo-advanced-binding-options.adoc
  • projecting-binding-data.adoc
  • understanding-service-binding-operator.adoc
  • installing-sbo.adoc
  • binding-workloads-using-sbo.adoc
  • exposing-binding-data-from-a-service.adoc
  • getting-started-with-service-binding.adoc
  • odc-connecting-an-application-to-a-service-using-the-developer-perspective.adoc

rolfedh
rolfedh reviewed Feb 14, 2022
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Sri. I've made some suggestions.

dperaza4dustbit
dperaza4dustbit reviewed Feb 15, 2022
View reviewed changes
Copy link

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good minor comment on number of components

@SNiemann15 SNiemann15 mentioned this pull request Feb 18, 2022
Merged
@Srivaralakshmi
Copy link
Contributor Author

@pmacik, @dperaza4dustbit, @baijum, and @rolfedh: I have addressed all the review comments. PTAL and provide feedback. Thanks!

@rolfedh
Copy link
Contributor

rolfedh commented Feb 21, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2022
@Srivaralakshmi
Copy link
Contributor Author

Srivaralakshmi commented Feb 22, 2022 •
edited
Loading

Hi @pmacik: Thanks for the approval.

@Srivaralakshmi
Quick start updates, Example updates, and Updates to SBO topics for m…
2fd1d2a 
…odular-docs template and content type attributes alignment

Fixing review comments

Fixing some more review comments

Fixed the RBAC requirements topic

Updated note section

Fixing the note section

Fixing the output in the note section

Fix QE review comments
@Srivaralakshmi Srivaralakshmi force-pushed the RefactorGettingStartedSBO branch from 78493cb to 2fd1d2a Compare February 22, 2022 16:25
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 22, 2022

New changes are detected. LGTM label has been removed.

@Preeticp Preeticp added branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 peer-review-done Signifies that the peer review team has reviewed this PR lgtm Indicates that a PR is ready to be merged. dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs labels Feb 22, 2022
@Preeticp Preeticp merged commit 1816807 into openshift:main Feb 22, 2022
@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.9

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.10

@Preeticp
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #42215

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Feb 22, 2022
Closed
Merged
@openshift-cherrypick-robot
Copy link

@Preeticp: new pull request created: #42216

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@Preeticp: cannot checkout enterprise-4.11: error checking out enterprise-4.11: exit status 1. output: error: pathspec 'enterprise-4.11' did not match any file(s) known to git

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dperaza4dustbit
dperaza4dustbit reviewed Feb 22, 2022
View reviewed changes
Copy link

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pneedle-rh
Copy link
Contributor

I closed the auto cherry pick PR for 4.9 #42215, because it had build failures. I will try to auto-generate another cherry pick PR for 4.9, because the build errors were resolved yesterday.

@pneedle-rh
Copy link
Contributor

/cherrypick enterprise-4.9

@openshift-cherrypick-robot
Copy link

@pneedle-rh: new pull request created: #42252

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 23, 2022
Merged
adellape added a commit to adellape/openshift-docs that referenced this pull request Feb 23, 2022
@adellape
Revert "Merge pull request openshift#41809 from Srivaralakshmi/Refact…
48a604a 
…orGettingStartedSBO"

This reverts commit 1816807, reversing
changes made to 08d83aa.
@adellape adellape mentioned this pull request Feb 23, 2022
Merged
Preeticp added a commit that referenced this pull request Feb 28, 2022
@Preeticp
Merge pull request #42305 from adellape/revert_sbo
5bb86c0 
Revert "Merge pull request #41809 from Srivaralakshmi/RefactorGetting…
aireilly pushed a commit to aireilly/openshift-docs that referenced this pull request Mar 15, 2022
@adellape @aireilly
Revert "Merge pull request openshift#41809 from Srivaralakshmi/Refact…
72ad886 
…orGettingStartedSBO"

This reverts commit 1816807, reversing
changes made to 08d83aa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SNiemann15 SNiemann15 SNiemann15 left review comments

@dperaza4dustbit dperaza4dustbit dperaza4dustbit left review comments

@pmacik pmacik pmacik left review comments

@rolfedh rolfedh rolfedh approved these changes

Assignees

@rolfedh rolfedh

@pmacik pmacik

Labels
branch/enterprise-4.9 branch/enterprise-4.10 branch/enterprise-4.11 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Srivaralakshmi @rolfedh @pmacik @Preeticp @openshift-cherrypick-robot @pneedle-rh @dperaza4dustbit @SNiemann15