-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSMDOC169 Update CR configuring Jaeger. #30367
Conversation
Deploy preview for osdocs ready! Built with commit b621432 |
@rubenvp8510 please review this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JStickler I have added a couple of comments.
But I need confirmation from @jpkrohling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JStickler I have added a couple of comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JStickler LGTM. Thanks for the changes!
/cherry-pick enterprise-4.6 |
@neal-timpe: #30367 failed to apply on top of branch "enterprise-4.6":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick enterprise-4.7 |
@neal-timpe: #30367 failed to apply on top of branch "enterprise-4.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick enterprise-4.8 |
@neal-timpe: #30367 failed to apply on top of branch "enterprise-4.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[4.6] Manual CP OSSMDOC-169 Jaeger updates #30367
This PR:
◦ Updates the variable for the Jaeger version number
◦ Separates the parameters that the Operator uses from the ones passed to the object into separate tables (OSSMDOC-233)
◦ Adds a best practices topic for Jaeger (OSSMDOC-191)
◦ Adds a note to the Installing Jaeger assembly that Jaeger must be installed in the same namespace as the SMCP.
◦ Corrects the export command used in the Jaeger tutorial (OSSMDOC-240)
◦ Splits the ossm-configuring-jaeger topic to add a heading for Specifying an External Jaeger to aid findability.
◦ Adds a link in OSSM to the topic for how to configure an external ES instance. (Addressses comment in OSSMDOC-132)
◦ Fixes the heading levels in the Deploying Jaeger assembly
Main changes (splitting the parameter tables and new best practices topic) are in this topic -> https://deploy-preview-30367--osdocs.netlify.app/openshift-enterprise/latest/jaeger/jaeger_install/rhbjaeger-deploying.html