-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BZ1890663 Storage matrix needs updating for CNV 2.5 #26688
Conversation
The preview will be available shortly at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outside of my comment, just a note that I'm marking this for 4.7 as well, since it's targeted for master.
Need QE from @demilyc. Then this can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bgaydosrh Are you planning to add a column for VM Snapshots as well? I forget what we decided there.
Hi @aglitke - See closed PR #22638 - We pulled it as it wasn't tested for 2.4. Should I re-add that column? I can do that ASAP. Can you or someone on your team verify the data in this matrix is QE approved (tested) or get QE's attention? We need to have everything merged by 11/11. Thanks! Bob We reuse and conditionalize the content heavily for this feature, so here are test links to the current output from this doc file: https://bz1890663--ocpdocs.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virtual_disks/virt-features-for-storage.html As of 11/9 at 7:39 PM, @aglitke has approved the latest output with VM Snapshot column added and revised footnotes. |
9d0749b
to
e59fa35
Compare
1e9274a
to
882e489
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM now, just let me know when it's ready to merge!
No changes from QE on my content. There were changes from QE on the VM Import tables. A bug was created which Avital closed today. Her PR (#27300) has already been merged. @bergerhoffer has done peer review for my content in this PR, which has not changed since that review. So this PR is ready to merge. |
/cherrypick enterprise-4.7 |
/cherrypick enterprise-4.6 |
/cherrypick enterprise-4.5 |
@bergerhoffer: new pull request created: #27313 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bergerhoffer: new pull request created: #27314 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bergerhoffer: new pull request created: #27315 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Revising matrix to add the column: Storage-assisted virtual machine disk cloning
See Netify link for test build.
@aglitke - Questions:
Peer review needed and label enterprise-4.5 and enterprise-4.6.
Bob