Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ1890663 Storage matrix needs updating for CNV 2.5 #26688

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

bgaydosrh
Copy link

@bgaydosrh bgaydosrh commented Oct 23, 2020

Revising matrix to add the column: Storage-assisted virtual machine disk cloning

See Netify link for test build.

@aglitke - Questions:

  1. Do we want to add back the row OpenShift Container Platform container storage: RBD filesystem volumes? Or stick to block-only? Sorry, I probably asked you this before.
  2. I am also requesting this be labeled for merge to OpenShift 4.5 and 4.6... correct? I think you said that Cloning was supported last release?
  3. Who would you recommend to tag for QE sign-off?

Peer review needed and label enterprise-4.5 and enterprise-4.6.

Bob

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2020
@bgaydosrh bgaydosrh changed the title Revise matrix 1st draft BZ1890663 Storage matrix needs updating for CNV 2.5 Oct 23, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

Copy link

@aglitke aglitke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2020
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of my comment, just a note that I'm marking this for 4.7 as well, since it's targeted for master.

modules/virt-features-for-storage-matrix.adoc Outdated Show resolved Hide resolved
@bergerhoffer bergerhoffer added branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR labels Oct 29, 2020
@bergerhoffer bergerhoffer added this to the Next Release milestone Oct 29, 2020
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 2, 2020
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2020
@bgaydosrh
Copy link
Author

Need QE from @demilyc. Then this can be merged.

@ctomasko

Copy link

@aglitke aglitke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgaydosrh Are you planning to add a column for VM Snapshots as well? I forget what we decided there.

@bgaydosrh
Copy link
Author

bgaydosrh commented Nov 6, 2020

@bgaydosrh Are you planning to add a column for VM Snapshots as well? I forget what we decided there.

Hi @aglitke - See closed PR #22638 - We pulled it as it wasn't tested for 2.4. Should I re-add that column? I can do that ASAP. Can you or someone on your team verify the data in this matrix is QE approved (tested) or get QE's attention? We need to have everything merged by 11/11. Thanks! Bob

We reuse and conditionalize the content heavily for this feature, so here are test links to the current output from this doc file:

https://bz1890663--ocpdocs.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virtual_disks/virt-features-for-storage.html
https://bz1890663--ocpdocs.netlify.app/openshift-enterprise/latest/virt/virtual_machines/importing_vms/virt-importing-rhv-vm.html
https://bz1890663--ocpdocs.netlify.app/openshift-enterprise/latest/virt/virtual_machines/importing_vms/virt-importing-vmware-vm.html

As of 11/9 at 7:39 PM, @aglitke has approved the latest output with VM Snapshot column added and revised footnotes.

@bgaydosrh bgaydosrh force-pushed the BZ1890663 branch 3 times, most recently from 9d0749b to e59fa35 Compare November 9, 2020 17:28
@bgaydosrh bgaydosrh force-pushed the BZ1890663 branch 3 times, most recently from 1e9274a to 882e489 Compare November 9, 2020 22:47
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM now, just let me know when it's ready to merge!

@bgaydosrh
Copy link
Author

bgaydosrh commented Nov 12, 2020

No changes from QE on my content. There were changes from QE on the VM Import tables. A bug was created which Avital closed today. Her PR (#27300) has already been merged. @bergerhoffer has done peer review for my content in this PR, which has not changed since that review. So this PR is ready to merge.

@bergerhoffer bergerhoffer merged commit 828a857 into openshift:master Nov 12, 2020
@bergerhoffer
Copy link
Contributor

bergerhoffer commented Nov 12, 2020

/cherrypick enterprise-4.7

@bergerhoffer
Copy link
Contributor

bergerhoffer commented Nov 12, 2020

/cherrypick enterprise-4.6

@bergerhoffer
Copy link
Contributor

bergerhoffer commented Nov 12, 2020

/cherrypick enterprise-4.5

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 12, 2020

@bergerhoffer: new pull request created: #27313

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 12, 2020

@bergerhoffer: new pull request created: #27314

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 12, 2020

@bergerhoffer: new pull request created: #27315

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants