-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug 1724028 remove startingCSV line in section 2f #15932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bug says no QE, so LTGM.
/cherrypick enterprise-4.1 |
/cherrypick enterprise-4.2 |
@kalexand-rh: #15932 failed to apply on top of branch "enterprise-4.2":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kalexand-rh: new pull request created: #15935 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bobfuru the callout marker and line have been removed, but you also need to remove the callout listing for the marker that you removed: https://github.com/openshift/openshift-docs/pull/15932/files#diff-ed2514a91149983674ad7ff3485f7499R181. So <3> was removed, but the <3> explanation remains which is not right since there is nothing to correspond it to. Please submit a new PR to remove the <3> explanation as well. |
And now we also have a bug for it: https://bugzilla.redhat.com/show_bug.cgi?id=1731588 :) |
@vikram-redhat I have submitted a new PR per your note and bug 1731588 to remove the callout listing for the callout 3 marker. |
New PR is: #15959 |
Removed line 178 (step 2f): startingCSV: "elasticsearch-operator.v4.1.0"
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1724028
@openshift/team-documentation