Adds documentation for JENKINS_UC_INSECURE variable #15258
Conversation
openshift-ci-robot
added
the
size/S
|
@gabemontero and @bmcelvee could you please take a look? this is related to: |
|
Another PR from @bmcelvee is pending for the 4.x branch which adds Jenkins environment variable. So I created a PR on top of @bmcelvee 's PR => bmcelvee#2 |
| occur during Jenkins image build or if an extension of the Jenkins image is built or if you | ||
| run the jenkins image and leverage one of the options to download additional plugins | ||
| (use of s2i whith plugins.txt or use of `INSTALL_PLUGINS` environment variable. | ||
| To enable, set to `true`. |
| uses an invalid SSL certificate. This could be the case if a self hosted repository | ||
| using self-signed certificate with an unknow CA is used or if an enteprise proxy | ||
| performs man-in-the-middle interceptions. This variable applies to plugins downloads which may | ||
| occur during Jenkins image build or if an extension of the Jenkins image is built or if you |
There was a problem hiding this comment.
If the upper case “Jenkins” here are necessary?
There was a problem hiding this comment.
fixed, I set Jenkins with upper everywhere.
|
others lgtm |
|
The feature works, and doc LGTM , Thanks |
|
@bmcelvee - can this be merged? |
|
@vikram-redhat yes, thanks! |
|
@akram Thank you again for submitting this PR! I have two suggested changes: a typo correction and sentence re-write. If you wouldn't mind making those changes, then squashing your commits. I'll go ahead and get this PR merged and cherrypicked appropriately. Thanks again! |
akram
force-pushed
the
master-3-allow-plugin-download-to-use-an-insecure-repository
branch
from
5d60520 to
52ff60b
Compare
|
Hi @bmcelvee |
|
@akram - thanks! I'll go ahead and merge and cherrypick to 3.11. How many versions back are the changes applicable? |
|
/cherrypick enterprise-3.11 |
|
@bmcelvee: new pull request created: #16161 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
only for 3.11 |
|
Perfect! We should be all set on this one, then. Thanks again! |
Adds documentation for JENKINS_UC_INSECURE variable