Skip to content

Commit

Permalink
Merge pull request #60554 from openshift-cherrypick-robot/cherry-pick…
Browse files Browse the repository at this point in the history
…-60258-to-enterprise-4.13

[enterprise-4.13] OCPBUGS13384: Examples for layering custom content should not have invalid image links
  • Loading branch information
mburke5678 authored May 25, 2023
2 parents 9d8abe9 + fc9026e commit cff7249
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions modules/coreos-layering-configuring.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ For example, the following Containerfile creates a custom layered image from an
[source,yaml]
----
# Using a 4.12.0 image
FROM quay.io/openshift-release/ocp-release@sha256:6499bc69a0707fcad481c3cb73225b867d <1>
FROM quay.io/openshift-release/ocp-release@sha256... <1>
#Install hotfix rpm
RUN rpm-ostree override replace https://example.com/hotfixes/haproxy-1.0.16-5.el8.src.rpm && \ <2>
rpm-ostree cleanup -m && \
ostree container commit
----
<1> Specifies an {product-title} release image.
<1> Specifies the {op-system} base image of your cluster.
<2> Specifies the path to the Hotfix package.
+
[NOTE]
Expand All @@ -63,7 +63,7 @@ metadata:
machineconfiguration.openshift.io/role: worker <1>
name: os-layer-custom
spec:
osImageURL: quay.io/my-registry/custom-image@sha256:306b606615dcf8f0e5e7d87fee3 <2>
osImageURL: quay.io/my-registry/custom-image@sha256... <2>
----
<1> Specifies the machine config pool to apply the custom layered image.
<2> Specifies the path to the custom layered image in the repository.
Expand Down Expand Up @@ -133,7 +133,7 @@ Annotations: machineconfiguration.openshift.io/generated-by-controller-version:
API Version: machineconfiguration.openshift.io/v1
Kind: MachineConfig
...
Os Image URL: quay.io/my-registry/custom-image@sha256:306b606615dcf8f0e5e7d87fee3
Os Image URL: quay.io/my-registry/custom-image@sha256...
----

.. Check that the associated machine config pool is updating with the new machine config:
Expand Down Expand Up @@ -199,7 +199,7 @@ sh-4.4# sudo rpm-ostree status
----
State: idle
Deployments:
* ostree-unverified-registry:quay.io/my-registry/custom-image@sha256:306b606615dcf8f0e5e7d87fee3
Digest: sha256:306b606615dcf8f0e5e7d87fee3
* ostree-unverified-registry:quay.io/my-registry/...
Digest: sha256:...
----

4 changes: 2 additions & 2 deletions post_installation_configuration/coreos-layering.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ In the event you want a Hotfix, it will be provided to you based on link:https:/
[source,yaml]
----
# Using a 4.12.0 image
FROM quay.io/openshift-release-dev/ocp-release@sha256:6499bc69a0707fcad481c3cb73225b867d
FROM quay.io/openshift-release-dev/ocp-release@sha256...
#Install hotfix rpm
RUN rpm-ostree override replace https://example.com/myrepo/haproxy-1.0.16-5.el8.src.rpm && \
rpm-ostree cleanup -m && \
Expand All @@ -56,7 +56,7 @@ RUN rpm-ostree override replace https://example.com/myrepo/haproxy-1.0.16-5.el8.
.Example Containerfile to apply the firewalld utility
[source,yaml]
----
FROM quay.io/openshift-release-dev/ocp-release@sha256:6499bc69a0707fcad481c3cb73225b867d
FROM quay.io/openshift-release-dev/ocp-release@sha256...
ADD configure-firewall-playbook.yml .
RUN rpm-ostree install firewalld ansible && \
ansible-playbook configure-firewall-playbook.yml && \
Expand Down

0 comments on commit cff7249

Please sign in to comment.