Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove std_include from playbooks/byo/rhel_subscribe.yml #4053

Merged
merged 1 commit into from
May 2, 2017
Merged

Remove std_include from playbooks/byo/rhel_subscribe.yml #4053

merged 1 commit into from
May 2, 2017

Conversation

abutcher
Copy link
Member

@abutcher abutcher commented May 1, 2017 •
edited
Loading

@abutcher abutcher requested a review from tbielawa May 1, 2017 15:06
@cooktheryan
Copy link
Contributor

<3 u da bes hoss

@tbielawa
Copy link
Contributor

tbielawa commented May 1, 2017

testing now

tbielawa
tbielawa approved these changes May 1, 2017
View reviewed changes
Copy link
Contributor

@tbielawa tbielawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me!!!!11

@abutcher
Copy link
Member Author

abutcher commented May 1, 2017

aos-ci-test

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" for 58d7c52 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for 58d7c52 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_containerized, aos-ci-jenkins/OS_3.5_containerized_e2e_tests" for 58d7c52 (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for 58d7c52 (logs)

@abutcher
Copy link
Member Author

abutcher commented May 1, 2017

[merge]

@openshift-bot
Copy link

[test]ing while waiting on the merge queue

mtnbikenc
mtnbikenc reviewed May 1, 2017
View reviewed changes
playbooks/byo/rhel_subscribe.yml Outdated
@@ -3,7 +3,7 @@
tags:
- always

- include: ../common/openshift-cluster/std_include.yml
- include: ../common/openshift-cluster/evaluate_groups.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evaluate_groups.yml is not even needed here either. This line can just be removed. See https://github.com/openshift/openshift-ansible/pull/4045/files#diff-377065f5e66159003edb0fc50ed24ee4R11

@abutcher abutcher force-pushed the rhsub-sans-std-include branch from 58d7c52 to d16d907 Compare May 1, 2017 19:48
@abutcher abutcher force-pushed the rhsub-sans-std-include branch from d16d907 to 5e321be Compare May 1, 2017 19:49
@abutcher
Copy link
Member Author

abutcher commented May 1, 2017

aos-ci-test

@openshift-bot
Copy link

Evaluated for openshift ansible test up to 5e321be

@openshift-bot
Copy link

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/90/) (Base Commit: 6ef6d1d)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" for 5e321be (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for 5e321be (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_containerized, aos-ci-jenkins/OS_3.5_containerized_e2e_tests" for 5e321be (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for 5e321be (logs)

@abutcher
Copy link
Member Author

abutcher commented May 2, 2017

flake openshift/origin#13942

@abutcher
Copy link
Member Author

abutcher commented May 2, 2017

[merge]

@openshift-bot
Copy link

Evaluated for openshift ansible merge up to 5e321be

@openshift-bot
Copy link

openshift-bot commented May 2, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/320/) (Base Commit: 0ea1e38)

@openshift-bot openshift-bot merged commit 708afd1 into openshift:master May 2, 2017
@sdodson
Copy link
Member

sdodson commented May 9, 2017

@abutcher pick into release-1.5?

@abutcher abutcher deleted the rhsub-sans-std-include branch May 19, 2017 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnbikenc mtnbikenc mtnbikenc left review comments

@tbielawa tbielawa tbielawa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@abutcher @cooktheryan @tbielawa @openshift-bot @sdodson @mtnbikenc