-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jinja template delimeters and quotes from when conditions #3975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quotes are no longer necessary with the removal of the delimiters. Just a nit, but still LGTM. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: perhaps double quotes may go as well
829e45f
to
3b85456
Compare
When starting conditionals with single quotes, the double quotes are still required. See errors in Travis. |
86ccb8b
to
9232a14
Compare
In ansible 2.3 "[WARNING]: when statements should not include jinja2 templating delimiters such as {{ }} or {% %}. Found: {{ g_glusterfs_hosts is not defined }}"
9232a14
to
717c36f
Compare
Rebased. |
aos-ci-test |
Evaluated for openshift ansible merge up to 717c36f |
flake openshift/origin#13980 |
[merge] |
[test]ing while waiting on the merge queue |
Evaluated for openshift ansible test up to 717c36f |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/91/) (Base Commit: 2852eec) |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/315/) (Base Commit: 4c2f899) |
In ansible 2.3 "[WARNING]: when statements should not include jinja2
templating delimiters such as {{ }} or {% %}. Found: {{
g_glusterfs_hosts is not defined }}"