Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jinja template delimeters and quotes from when conditions #3975

Merged
merged 2 commits into from
May 2, 2017

Conversation

sdodson
Copy link
Member

@sdodson sdodson commented Apr 21, 2017

In ansible 2.3 "[WARNING]: when statements should not include jinja2
templating delimiters such as {{ }} or {% %}. Found: {{
g_glusterfs_hosts is not defined }}"

mtnbikenc
mtnbikenc previously approved these changes Apr 26, 2017
Copy link
Member

@mtnbikenc mtnbikenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quotes are no longer necessary with the removal of the delimiters. Just a nit, but still LGTM. 👍

Copy link
Contributor

@bogdando bogdando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: perhaps double quotes may go as well

@sdodson sdodson force-pushed the ansible_23_warnings branch from 829e45f to 3b85456 Compare April 27, 2017 13:31
@sdodson sdodson changed the title Remove jinja template delimeters from when conditions Remove jinja template delimeters and quotes from when conditions Apr 27, 2017
@mtnbikenc
Copy link
Member

When starting conditionals with single quotes, the double quotes are still required. See errors in Travis.

@mtnbikenc mtnbikenc dismissed their stale review April 27, 2017 19:10

Need to fix travis testing errors

@sdodson sdodson force-pushed the ansible_23_warnings branch from 86ccb8b to 9232a14 Compare April 28, 2017 17:10
sdodson added 2 commits May 1, 2017 11:03
In ansible 2.3 "[WARNING]: when statements should not include jinja2
templating delimiters such as {{ }} or {% %}. Found: {{
g_glusterfs_hosts is not defined }}"
@sdodson sdodson force-pushed the ansible_23_warnings branch from 9232a14 to 717c36f Compare May 1, 2017 15:05
@sdodson
Copy link
Member Author

sdodson commented May 1, 2017

Rebased.

@sdodson
Copy link
Member Author

sdodson commented May 1, 2017

aos-ci-test

@openshift-bot
Copy link

Evaluated for openshift ansible merge up to 717c36f

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_NOT_containerized, aos-ci-jenkins/OS_3.5_NOT_containerized_e2e_tests" for 717c36f (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_NOT_containerized, aos-ci-jenkins/OS_3.6_NOT_containerized_e2e_tests" for 717c36f (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.5_containerized, aos-ci-jenkins/OS_3.5_containerized_e2e_tests" for 717c36f (logs)

@openshift-bot
Copy link

success: "aos-ci-jenkins/OS_3.6_containerized, aos-ci-jenkins/OS_3.6_containerized_e2e_tests" for 717c36f (logs)

@abutcher
Copy link
Member

abutcher commented May 1, 2017

flake openshift/origin#13980

@abutcher
Copy link
Member

abutcher commented May 1, 2017

[merge]

@openshift-bot
Copy link

[test]ing while waiting on the merge queue

@openshift-bot
Copy link

Evaluated for openshift ansible test up to 717c36f

@openshift-bot
Copy link

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/91/) (Base Commit: 2852eec)

@openshift-bot
Copy link

openshift-bot commented May 2, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/315/) (Base Commit: 4c2f899)

@openshift-bot openshift-bot merged commit 81cf512 into openshift:master May 2, 2017
@sdodson sdodson deleted the ansible_23_warnings branch May 11, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants