ensure/enable dependencies needed for FC24 #2674
Conversation
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch?
|
| - name: Ensure yum-utils is installed | ||
| action: "{{ ansible_pkg_mgr }} name=yum-utils state=present" | ||
| - name: Enable NetworkManager | ||
| service: name=NetworkManager enabled=yes state=started |
There was a problem hiding this comment.
We've deliberately avoided doing this because we've always seen it as being too risky. I'd prefer checking for this in a pre-requisites playbook so we get to it earlier than we are right now.
There was a problem hiding this comment.
Hmm - I agree, but on that point it might be good to move all package / distribution oriented tasks out of openshift_facts and into a pre-req playbook/task - this would make it easier to adapt openshift-ansible for Debian, etc...
There was a problem hiding this comment.
Yeah, we have a near term goal of moving that sort of stuff out of openshift_facts into a pre-req playbook so it's not called a dozen times or more. There's also #2152 that's related to this.
There was a problem hiding this comment.
There is also this PR that was recently merged that provides a byo playbook for installing and enabling NetworkManager: #2771
| with_items: | ||
| - PyYAML | ||
| - yum-utils | ||
| - dbus-python |
There was a problem hiding this comment.
That will install python 2 version of the dependencies, so I would suggest doing something like this:
with_items:
- "libsemanage-python{{ ansible_python['version']['major']}}"
- "python{{ ansible_python['version']['major']}}-dbus"
So this can be safely run on python 3 (I am currently testing ansible on python 3, and I was able to deploy on F24 with python 3 installed and used with ansible 2.2)
|
Also related #2840 (since F25 systemd is a bit less forgiving when NetworkManager is not installed) |
|
I also took a look at F25, and there is no NetworkManager, and you can't add dispatcher script to systemd-networkd (by design). |
|
Can one of the admins verify this patch? |
|
OpenShift Ansible Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again |
openshift-bot
added
the
needs-rebase
|
Can one of the admins verify this patch?
|
1 similar comment
|
Can one of the admins verify this patch?
|
|
@detiber Hello. I don't feel this PR is relevant anymore -- as I am setting up the prequisites outside of openshift-ansible. Closing... |
These packages are required in order to install on Fedora Cloud 24 -- as well, NetworkManager needs to be enabled and running.