Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable systemd-resolved DNS stub listener #15

Merged
merged 2 commits into from
Nov 22, 2020
Merged

Disable systemd-resolved DNS stub listener #15

merged 2 commits into from
Nov 22, 2020

Conversation

vrutkovs
Copy link
Member

CoreDNS doesn't play nice with default systemd-resolved configuration - see https://github.com/coredns/coredns/blob/master/plugin/loop/README.md#troubleshooting-loops-in-kubernetes-clusters.
OKD should boot with systemd-resolved enabled, but without DNS stub listener (127.0.0.53)
so that external DNS would be used

@openshift-ci-robot
Copy link

@vrutkovs: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

WIP disable systemd-resolved DNS stub listener

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2020
@vrutkovs
Copy link
Member Author

/test e2e-gcp

@vrutkovs vrutkovs force-pushed the 4.6-re-enable-resolved branch from 8c3d4b9 to ecca6ac Compare November 21, 2020 18:14
@vrutkovs
Copy link
Member Author

/test e2e-gcp

@vrutkovs vrutkovs force-pushed the 4.6-re-enable-resolved branch 4 times, most recently from e171d3e to bb5e021 Compare November 22, 2020 08:14
@vrutkovs
overlay: disable systemd-resolved DNS stub listener
98330dc 
CoreDNS doesn't play nice with default systemd-resolved configuration - see coredns/coredns@master/plugin/loop/README.md#troubleshooting-loops-in-kubernetes-clusters.
OKD should boot with systemd-resolved enabled, but without DNS stub listener (127.0.0.53)
so that external DNS would be used
@vrutkovs vrutkovs force-pushed the 4.6-re-enable-resolved branch from bb5e021 to 98330dc Compare November 22, 2020 08:14
@vrutkovs
Copy link
Member Author

/test e2e-gcp

@vrutkovs
Copy link
Member Author

/test e2e-vsphere

@vrutkovs vrutkovs mentioned this pull request Nov 22, 2020
Closed
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 22, 2020 •
edited
Loading

@vrutkovs: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere 98330dc link /test e2e-vsphere

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Member Author

/test e2e-gcp

@vrutkovs vrutkovs changed the title WIP disable systemd-resolved DNS stub listener Disable systemd-resolved DNS stub listener Nov 22, 2020
@openshift-ci-robot
Copy link

@vrutkovs: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Disable systemd-resolved DNS stub listener

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2020
@vrutkovs vrutkovs added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. labels Nov 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit 4a321b0 into openshift:release-4.6 Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorbusChris LorbusChris Awaiting requested review from LorbusChris

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vrutkovs @openshift-ci-robot @openshift-merge-robot