Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s dependencies to 0.28.2 #291

Merged

Conversation

rhmdnd
Copy link
Contributor

@rhmdnd rhmdnd commented Sep 14, 2023

Update all the k8s dependencies together. Sometimes when we, or
dependabot, attempt to update dependencies separately, we get build
errors because k8s libraries are expected to run with the same semantic
version. This is noted in kubernetes/client-go#1269

Let's group the k8s dependencies into a single patch so we reduce the
possibility of build issues due to compatibility issues between client
libraries.

Update all the k8s dependencies together. Sometimes when we, or
dependabot, attempt to update dependencies separately, we get build
errors because k8s libraries are expected to run with the same semantic
version. This is noted in kubernetes/client-go#1269

Let's group the k8s dependencies into a single patch so we reduce the
possibility of build issues due to compatibility issues between client
libraries.
Copy link
Contributor

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

@rhmdnd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6472062 into openshift:master Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants