Virtualization E2E tests on OpenStack #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only clean it up if the test downloaded it in the first place. Signed-off-by: Matthew Arnold <[email protected]>
Allow KVM emulation to be configured, and add an OpenStack provider that copies AWS except for leaving emulation turned off. Signed-off-by: Matthew Arnold <[email protected]>
If the test did not need to create an immediate-mode storage class (because the default was already set to immediate), make sure it does not try to delete anything after the test is done. Previously this would cause an error after all the tests were run, even if they were all successful. Signed-off-by: Matthew Arnold <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
approved
Otherwise the previously-default WFFC tests will all run with Immediate, and make the Immediate-specific tests redundant. Signed-off-by: Matthew Arnold <[email protected]>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
just getting one ci run in :) feel free to re-hold |
Can't just use AWS for everything after all. Signed-off-by: Matthew Arnold <[email protected]>
|
Okay, I am seeing good data mover tests now. This should be good to run through CI to make sure I haven't broken anything. |
mrnold
changed the title
|
/retest |
weshayutin
approved these changes
Sep 12, 2024
shubham-pampattiwar
approved these changes
Sep 12, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrnold, shubham-pampattiwar, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
@mrnold: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
weshayutin
pushed a commit
to weshayutin/oadp-operator
that referenced
this pull request
Sep 13, 2024
* Avoid deleting previously installed CirrOS image. Only clean it up if the test downloaded it in the first place. Signed-off-by: Matthew Arnold <[email protected]> * Default OpenStack provider to no KVM emulation. Allow KVM emulation to be configured, and add an OpenStack provider that copies AWS except for leaving emulation turned off. Signed-off-by: Matthew Arnold <[email protected]> * Avoid trying to delete non-existent storage class. If the test did not need to create an immediate-mode storage class (because the default was already set to immediate), make sure it does not try to delete anything after the test is done. Previously this would cause an error after all the tests were run, even if they were all successful. Signed-off-by: Matthew Arnold <[email protected]> * Create WFFC storage class if default is Immediate. Otherwise the previously-default WFFC tests will all run with Immediate, and make the Immediate-specific tests redundant. Signed-off-by: Matthew Arnold <[email protected]> * Add test scripts for OpenStack. Can't just use AWS for everything after all. Signed-off-by: Matthew Arnold <[email protected]> --------- Signed-off-by: Matthew Arnold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes were made
This adds an E2E OpenStack provider that gets VM tests working on PSI, using an AWS bucket as the backup location. Includes a handful of tweaks like making KVM emulation configurable, creating a WFFC storage class when the default is Immediate, and creating a VolumeSnapshotClass for Ceph RBD.
How to test the changes made
Log in to shared PSI cluster, set up AWS bucket as per usual instructions, then make TEST_VIRT=true test-e2e.