Upgrade GetBucketRegion to aws-sdk-go-v2

[kaovilai]

Signed-off-by: Tiger Kaovilai [email protected]

Why the changes were made

To test that aws-sdk-go-v2 upgrade in aws plugin did not break bucket discovery to debug #1451 failures.

How to test the changes made

go test ./pkg/storage/aws/...

Followup

• Move CloudStorageAPI for aws to aws-sdk-go-v2 #1471

[kaovilai]

TODO: Move CloudStorageAPI for aws to aws-sdk-go-v2

[kaovilai]

--- FAIL: TestDPAReconciler_ValidateBackupStorageLocations (0.01s)
    --- FAIL: TestDPAReconciler_ValidateBackupStorageLocations/BSL_Region_not_set_for_aws_provider_without_S3ForcePathStyle_with_BackupImages_false_expect_to_succeed (0.00s)
        bsl_test.go:1503: ValidateBackupStorageLocations() error = region for AWS backupstoragelocation not automatically discoverable. Please set the region in the backupstoragelocation config, wantErr false

uhoh unit test

[kaovilai]

the ValidateBSL unit test' bucket does work in s3_test.go so I think might be same issue we're hitting elsewhere?

[kaovilai]

FWIW the same suite test works locally

❯ go test -run TestDPAReconciler_ValidateBackupStorageLocations ./controllers/...
ok      github.com/openshift/oadp-operator/controllers  1.361s

[weshayutin]

glad we tested this in the scrum lolz 0/

[kaovilai]

/retest

[kaovilai]

TODO: use credentials to query region on non-public buckets
https://docs.aws.amazon.com/AmazonS3/latest/API/API_HeadBucket.html#:~:text=Request%20to%20public%20buckets%20that%20grant%20the%20s3%3AListBucket%20permission%20publicly%20do%20not%20need%20to%20be%20signed.

aws/aws-sdk-go-v2#2716.

[weshayutin]

thanks @kaovilai

[kaovilai]

FYI the PR in velero is practically similar to this except that they use real credentials. I do not think it is urgent or practical to do so as far as unit test goes.. but we can implement this in the prod env as a follow up.

Benefit to real creds as opposed to anonymous is it can list bucket regions for private buckets.

[shubham-pampattiwar]

/lgtm

[kaovilai]

/unhold

updated PR description

[mateusoliveira43]

/retest
post restore flake (deployment/deploymentConfig not available)

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43, mrnold, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kaovilai,mateusoliveira43,mrnold,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mateusoliveira43]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 510c203 and 2 for PR HEAD a56c3d5 in total

[openshift-ci]

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.