OCPBUGS-37991: Downstream sync to address multiple interface returns in network-status annotation #245
Conversation
interface name should not be limited to DNS-1123 label format. instead validate interface name if provided in pod network annotation in a similar manner as iproute2[1]. this will allow to request interface names such as: "uplink_p0" [1]https://github.com/iproute2/iproute2/blob/11740815bfe69d6ee2cad7c608a8edc70147209a/lib/utils.c#L832 Signed-off-by: adrianc <[email protected]>
Signed-off-by: Moshe Levi <[email protected]>
Signed-off-by: Moshe Levi <[email protected]>
Signed-off-by: Vasilis Remmas <[email protected]>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.17.0 to 0.23.0. - [Commits](golang/net@v0.17.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Multus v3.9.3 has `--multus-master-cni-file-name` flag to specify the name of a primary CNI config file. https://github.com/k8snetworkplumbingwg/multus-cni/blob/v3.9.3/images/entrypoint.sh#L22 In Multus v4.0.2, the thin plugin has the flag defined, but it is not read and so does not have effect. This pull request fixes the problem by making the thin plugin correctly handles `--multus-master-cni-file-name` flag. Fixes #1226 Signed-off-by: Hidehito Yabuuchi <[email protected]>
…les/golang.org/x/net-0.23.0 Bump golang.org/x/net from 0.17.0 to 0.23.0
rename conf param, 'defaultnetworkfile' to 'readinessindicatorfile'
Fix defaultnetworkfile in unit test
deleteDefaultGWResult() may create 'routes:null' in CNI cache file and it causes nil pointer access at addDefaultGWCacheBytes(). This code change prevents deleteDefaultGWResult() to generate 'routes:null' in cache file.
Fix CNI cache update function to prevent nil access
thin plugin: Handle `--multus-master-cni-file-name` flag
Signed-off-by: Vasilis Remmas <[email protected]>
This modifies the behavior on CNI DEL for the thick plugin to just check once for API readiness, as opposed to waiting.
Thick plugin should not wait for API readiness on CNI DEL
Fixes: k8snetworkplumbingwg/multus-cni#1281 Signed-off-by: Adrian Vladu <[email protected]>
Change Validation of interface name
add support for Dynamic Resource Allocation
APIReadyCheckFunc is used only in api, hence it can be decapitalize to make its scope only in this package. This fix changes its scope. In addition, api.APIReadyCheckFunc seems to be redundant so the name is changed. Change the comment to fit to golang style, too.
Not exposed APIReadyCheckFunc to outside of package
arm64: build image for arm v8
This is needed to avoid issues with volume unmounts when (other) pods exit as by default kubernetes mounts as private. Signed-off-by: adrianc <[email protected]>
…elet Add mountPropagation to host-var-lib-kubelet
typo KUBERNETES_SERVICE_PROTOCOL
Update how-to-use.md
this provides a simple way to handle incoming os signas using context Signed-off-by: adrianc <[email protected]>
- if cleanup-config-on-exit is set delete generated multus config file on exit. - add an option to skip watch for master cni config and kubeconfig as cleanup-config-on-exit with multus-conf-file=auto also triggered the watch for cases when deletion of multus config is desired but watch isnt - setup signal handling to allow config file cleanup on exit Signed-off-by: adrianc <[email protected]>
Signed-off-by: Vasilis Remmas <[email protected]>
Updates to use CreateNetworkStauses from net-attach-def client, bump to v1.7.1
Corrects conflict to api/shim.go
openshift-ci
bot
added
the
approved
|
/restest_required |
|
/retest-required |
|
@dougbtv: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/title OCPBUGS-37991: Downstream sync to address multiple interface returns in network-status annotation |
|
/retitle OCPBUGS-37991: Downstream sync to address multiple interface returns in network-status annotation |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-important
|
@dougbtv: This pull request references Jira Issue OCPBUGS-37991, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
|
@dougbtv: This pull request references Jira Issue OCPBUGS-37991, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@dougbtv: This pull request references Jira Issue OCPBUGS-37991, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
Quick note, this is my first downstream merge review so if I miss anything sorry in advance |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bpickard22, dougbtv The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dougbtv: Jira Issue OCPBUGS-37991: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-37991 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: multus-cni-container-microshift |
Notably includes https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/releases/tag/v1.7.1 in order to fix up status annotations when a delegated plugin has multiple pod interfaces in the CNI result.