Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin setup-envtest #69

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Pin setup-envtest #69

merged 1 commit into from
Apr 3, 2024

Conversation

aleskandro
Copy link
Member

@aleskandro aleskandro commented Apr 2, 2024

setup-envtest is installed in the automatically generated makefile target.
Pinning its version to avoid updates to its repo like the minimum golang version in the go.mod can break compatibility and CI.

See kubernetes-sigs/kubebuilder#2480

Blocks #62 #66 #67 #68

@openshift-ci openshift-ci bot requested a review from Prashanth684 April 2, 2024 15:04
@aleskandro aleskandro force-pushed the mods branch 2 times, most recently from dab62e8 to d6463b7 Compare April 2, 2024 15:45
setup-envtest is installed in the automatically generated makefile target.
Pinning its version to avoid updates to its repo like the minimum golang version in the go.mod can break compatibility and CI.

See kubernetes-sigs/kubebuilder#2480
@aleskandro
Copy link
Member Author

/approve

@AnnaZivkovic
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleskandro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD af0fcb1 and 2 for PR HEAD 42aebd7 in total

@aleskandro
Copy link
Member Author

/override e2e-gcp-multi-operator-olm

Copy link

openshift-ci bot commented Apr 2, 2024

@aleskandro: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-gcp-multi-operator-olm

Only the following failed contexts/checkruns were expected:

  • Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator
  • Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator-bundle
  • ci/prow/ci-index-multiarch-tuning-operator-bundle
  • ci/prow/e2e-gcp-multi-operator
  • ci/prow/e2e-gcp-multi-operator-olm
  • ci/prow/fmt
  • ci/prow/generate
  • ci/prow/goimports
  • ci/prow/images
  • ci/prow/lint
  • ci/prow/manifests
  • ci/prow/sast
  • ci/prow/security
  • ci/prow/unit
  • ci/prow/vendor
  • ci/prow/vet
  • pull-ci-openshift-multiarch-tuning-operator-main-ci-index-multiarch-tuning-operator-bundle
  • pull-ci-openshift-multiarch-tuning-operator-main-e2e-gcp-multi-operator
  • pull-ci-openshift-multiarch-tuning-operator-main-e2e-gcp-multi-operator-olm
  • pull-ci-openshift-multiarch-tuning-operator-main-fmt
  • pull-ci-openshift-multiarch-tuning-operator-main-generate
  • pull-ci-openshift-multiarch-tuning-operator-main-goimports
  • pull-ci-openshift-multiarch-tuning-operator-main-images
  • pull-ci-openshift-multiarch-tuning-operator-main-lint
  • pull-ci-openshift-multiarch-tuning-operator-main-manifests
  • pull-ci-openshift-multiarch-tuning-operator-main-sast
  • pull-ci-openshift-multiarch-tuning-operator-main-security
  • pull-ci-openshift-multiarch-tuning-operator-main-unit
  • pull-ci-openshift-multiarch-tuning-operator-main-vendor
  • pull-ci-openshift-multiarch-tuning-operator-main-vet
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-gcp-multi-operator-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aleskandro
Copy link
Member Author

/override pull-ci-e2e-gcp-multi-operator-olm

1 similar comment
@aleskandro
Copy link
Member Author

/override pull-ci-e2e-gcp-multi-operator-olm

Copy link

openshift-ci bot commented Apr 2, 2024

@aleskandro: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • pull-ci-e2e-gcp-multi-operator-olm

Only the following failed contexts/checkruns were expected:

  • Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator
  • Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator-bundle
  • ci/prow/ci-index-multiarch-tuning-operator-bundle
  • ci/prow/e2e-gcp-multi-operator
  • ci/prow/e2e-gcp-multi-operator-olm
  • ci/prow/fmt
  • ci/prow/generate
  • ci/prow/goimports
  • ci/prow/images
  • ci/prow/lint
  • ci/prow/manifests
  • ci/prow/sast
  • ci/prow/security
  • ci/prow/unit
  • ci/prow/vendor
  • ci/prow/vet
  • pull-ci-openshift-multiarch-tuning-operator-main-ci-index-multiarch-tuning-operator-bundle
  • pull-ci-openshift-multiarch-tuning-operator-main-e2e-gcp-multi-operator
  • pull-ci-openshift-multiarch-tuning-operator-main-e2e-gcp-multi-operator-olm
  • pull-ci-openshift-multiarch-tuning-operator-main-fmt
  • pull-ci-openshift-multiarch-tuning-operator-main-generate
  • pull-ci-openshift-multiarch-tuning-operator-main-goimports
  • pull-ci-openshift-multiarch-tuning-operator-main-images
  • pull-ci-openshift-multiarch-tuning-operator-main-lint
  • pull-ci-openshift-multiarch-tuning-operator-main-manifests
  • pull-ci-openshift-multiarch-tuning-operator-main-sast
  • pull-ci-openshift-multiarch-tuning-operator-main-security
  • pull-ci-openshift-multiarch-tuning-operator-main-unit
  • pull-ci-openshift-multiarch-tuning-operator-main-vendor
  • pull-ci-openshift-multiarch-tuning-operator-main-vet
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override pull-ci-e2e-gcp-multi-operator-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Apr 2, 2024

@aleskandro: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • pull-ci-e2e-gcp-multi-operator-olm

Only the following failed contexts/checkruns were expected:

  • Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator
  • Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator-bundle
  • ci/prow/ci-index-multiarch-tuning-operator-bundle
  • ci/prow/e2e-gcp-multi-operator
  • ci/prow/e2e-gcp-multi-operator-olm
  • ci/prow/fmt
  • ci/prow/generate
  • ci/prow/goimports
  • ci/prow/images
  • ci/prow/lint
  • ci/prow/manifests
  • ci/prow/sast
  • ci/prow/security
  • ci/prow/unit
  • ci/prow/vendor
  • ci/prow/vet
  • pull-ci-openshift-multiarch-tuning-operator-main-ci-index-multiarch-tuning-operator-bundle
  • pull-ci-openshift-multiarch-tuning-operator-main-e2e-gcp-multi-operator
  • pull-ci-openshift-multiarch-tuning-operator-main-e2e-gcp-multi-operator-olm
  • pull-ci-openshift-multiarch-tuning-operator-main-fmt
  • pull-ci-openshift-multiarch-tuning-operator-main-generate
  • pull-ci-openshift-multiarch-tuning-operator-main-goimports
  • pull-ci-openshift-multiarch-tuning-operator-main-images
  • pull-ci-openshift-multiarch-tuning-operator-main-lint
  • pull-ci-openshift-multiarch-tuning-operator-main-manifests
  • pull-ci-openshift-multiarch-tuning-operator-main-sast
  • pull-ci-openshift-multiarch-tuning-operator-main-security
  • pull-ci-openshift-multiarch-tuning-operator-main-unit
  • pull-ci-openshift-multiarch-tuning-operator-main-vendor
  • pull-ci-openshift-multiarch-tuning-operator-main-vet
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override pull-ci-e2e-gcp-multi-operator-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lwan-wanglin
Copy link
Contributor

/test e2e-gcp-multi-operator-olm

Copy link

openshift-ci bot commented Apr 3, 2024

@aleskandro: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aleskandro
Copy link
Member Author

/override "Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator" "Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator-bundle"

Copy link

openshift-ci bot commented Apr 3, 2024

@aleskandro: Overrode contexts on behalf of aleskandro: Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator, Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator-bundle

In response to this:

/override "Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator" "Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator-bundle"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit b71f8bf into openshift:main Apr 3, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants