Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-5367: Increase the max_connections setting of Postgres to improve mirror registry stability #4523

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Feb 9, 2025

Should help mitigating the following errors in CI.

2025-02-09T16:04:16.683889000Z gunicorn-registry stdout | 2025-02-09 16:04:16,679 [330] [ERROR] [gunicorn.error] Error handling request /v2/auth?account=microshift&scope=repository%3Amicroshift%2Frhel94-bootc-yminus2%3Apull%2Cpush&scope=repository%3Amicroshift%2Frhel94-bootc-prel%3Apull&service=i-020da06ecb9dac2ef.us-west-2.compute.internal%3A5000
2025-02-09T16:04:16.683942000Z gunicorn-registry stdout | Traceback (most recent call last):
2025-02-09T16:04:16.683970000Z gunicorn-registry stdout |   File "/app/lib/python3.9/site-packages/peewee.py", line 2993, in connect
2025-02-09T16:04:16.684005000Z gunicorn-registry stdout |     self._state.set_connection(self._connect())
2025-02-09T16:04:16.684032000Z gunicorn-registry stdout |   File "/app/lib/python3.9/site-packages/playhouse/pool.py", line 156, in _connect
2025-02-09T16:04:16.684058000Z gunicorn-registry stdout |     conn = super(PooledDatabase, self)._connect()
2025-02-09T16:04:16.684084000Z gunicorn-registry stdout |   File "/app/lib/python3.9/site-packages/peewee.py", line 3688, in _connect
2025-02-09T16:04:16.684109000Z gunicorn-registry stdout |     conn = psycopg2.connect(database=self.database, **self.connect_params)
2025-02-09T16:04:16.684135000Z gunicorn-registry stdout |   File "/app/lib/python3.9/site-packages/psycopg2/__init__.py", line 122, in connect
2025-02-09T16:04:16.684161000Z gunicorn-registry stdout |     conn = _connect(dsn, connection_factory=connection_factory, **kwasync)
2025-02-09T16:04:16.684188000Z gunicorn-registry stdout | psycopg2.OperationalError: FATAL:  sorry, too many clients already 

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2025

@ggiguash: This pull request references USHIFT-5367 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Should help avoiding the following errors in CI.

2025-02-09T16:04:16.683889000Z gunicorn-registry stdout | 2025-02-09 16:04:16,679 [330] [ERROR] [gunicorn.error] Error handling request /v2/auth?account=microshift&scope=repository%3Amicroshift%2Frhel94-bootc-yminus2%3Apull%2Cpush&scope=repository%3Amicroshift%2Frhel94-bootc-prel%3Apull&service=i-020da06ecb9dac2ef.us-west-2.compute.internal%3A5000
2025-02-09T16:04:16.683942000Z gunicorn-registry stdout | Traceback (most recent call last):
2025-02-09T16:04:16.683970000Z gunicorn-registry stdout |   File "/app/lib/python3.9/site-packages/peewee.py", line 2993, in connect
2025-02-09T16:04:16.684005000Z gunicorn-registry stdout |     self._state.set_connection(self._connect())
2025-02-09T16:04:16.684032000Z gunicorn-registry stdout |   File "/app/lib/python3.9/site-packages/playhouse/pool.py", line 156, in _connect
2025-02-09T16:04:16.684058000Z gunicorn-registry stdout |     conn = super(PooledDatabase, self)._connect()
2025-02-09T16:04:16.684084000Z gunicorn-registry stdout |   File "/app/lib/python3.9/site-packages/peewee.py", line 3688, in _connect
2025-02-09T16:04:16.684109000Z gunicorn-registry stdout |     conn = psycopg2.connect(database=self.database, **self.connect_params)
2025-02-09T16:04:16.684135000Z gunicorn-registry stdout |   File "/app/lib/python3.9/site-packages/psycopg2/__init__.py", line 122, in connect
2025-02-09T16:04:16.684161000Z gunicorn-registry stdout |     conn = _connect(dsn, connection_factory=connection_factory, **kwasync)
2025-02-09T16:04:16.684188000Z gunicorn-registry stdout | psycopg2.OperationalError: FATAL:  sorry, too many clients already 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 9, 2025
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2025

@ggiguash: This pull request references USHIFT-5367 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Should help mitigating the following errors in CI.

2025-02-09T16:04:16.683889000Z gunicorn-registry stdout | 2025-02-09 16:04:16,679 [330] [ERROR] [gunicorn.error] Error handling request /v2/auth?account=microshift&scope=repository%3Amicroshift%2Frhel94-bootc-yminus2%3Apull%2Cpush&scope=repository%3Amicroshift%2Frhel94-bootc-prel%3Apull&service=i-020da06ecb9dac2ef.us-west-2.compute.internal%3A5000
2025-02-09T16:04:16.683942000Z gunicorn-registry stdout | Traceback (most recent call last):
2025-02-09T16:04:16.683970000Z gunicorn-registry stdout |   File "/app/lib/python3.9/site-packages/peewee.py", line 2993, in connect
2025-02-09T16:04:16.684005000Z gunicorn-registry stdout |     self._state.set_connection(self._connect())
2025-02-09T16:04:16.684032000Z gunicorn-registry stdout |   File "/app/lib/python3.9/site-packages/playhouse/pool.py", line 156, in _connect
2025-02-09T16:04:16.684058000Z gunicorn-registry stdout |     conn = super(PooledDatabase, self)._connect()
2025-02-09T16:04:16.684084000Z gunicorn-registry stdout |   File "/app/lib/python3.9/site-packages/peewee.py", line 3688, in _connect
2025-02-09T16:04:16.684109000Z gunicorn-registry stdout |     conn = psycopg2.connect(database=self.database, **self.connect_params)
2025-02-09T16:04:16.684135000Z gunicorn-registry stdout |   File "/app/lib/python3.9/site-packages/psycopg2/__init__.py", line 122, in connect
2025-02-09T16:04:16.684161000Z gunicorn-registry stdout |     conn = _connect(dsn, connection_factory=connection_factory, **kwasync)
2025-02-09T16:04:16.684188000Z gunicorn-registry stdout | psycopg2.OperationalError: FATAL:  sorry, too many clients already 

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash ggiguash marked this pull request as ready for review February 9, 2025 17:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2025
@openshift-ci openshift-ci bot requested review from eslutsky and jerpeter1 February 9, 2025 17:47
Copy link
Contributor

openshift-ci bot commented Feb 9, 2025

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2025
Copy link
Contributor

openshift-ci bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fec534f into openshift:main Feb 10, 2025
13 checks passed
@ggiguash
Copy link
Contributor Author

/cherry-pick release-4.18

@ggiguash ggiguash deleted the mirror_max_connections branch February 10, 2025 09:51
@openshift-cherrypick-robot

@ggiguash: new pull request created: #4530

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants