add docker.io registry

[rphillips]

Enables docker.io registries

[abhinavdahiya]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [abhinavdahiya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cgwalters]

I'll just continue my quest against this by commenting here:

https://bugzilla.redhat.com/show_bug.cgi?id=1434897#c7
https://url.corp.redhat.com/walters-registry-equality

[cgwalters]

(Why are we overriding the config files shipped in the RPMs anyways?)

[cgwalters]

Oh...this is probably because cri-o doesn't search docker.io by default right?

If that's breaking our code, and we are actually intending to pull containers from docker.io, I think we should explicitly spell that out in the configs.

[rphillips]

@cgwalters end users of containers usually expect docker pull busybox to pull the docker hub busybox.

[cgwalters]

(The question of it affecting users is IMO distinct...probably we should have a high level config knob in the installer to affect the registry search order)

@cgwalters end users of containers usually expect docker pull busybox to pull the docker hub busybox.

Right, but we're not shipping /usr/bin/docker.

[sjenning]

Oh...this is probably because cri-o doesn't search docker.io by default right?
If that's breaking our code, and we are actually intending to pull containers from docker.io, I think we should explicitly spell that out in the configs.

Completely agree and we are working to find all those places. We know the router, registry, and webconsole currently do not fully qualify their image paths.

Ideally we get to a world where the search list is empty and everyone fully qualifies their image paths.

[sjenning]

Backing up my claim https://github.com/coreos-inc/tectonic-operators/pull/463