OCPBUGS-48566: Enable nmstate-configuration on all platforms

[cybertron]

While we don't necessarily expect this to be used everywhere yet, we at least need to have it on platform None since that is used for a lot of baremetal deployments with assisted. There's not really any reason it can't be used on all platforms either.

- What I did

- How to verify it

- Description for the changelog

[openshift-ci-robot]

@cybertron: This pull request references Jira Issue OCPBUGS-48566, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

While we don't necessarily expect this to be used everywhere yet, we at least need to have it on platform None since that is used for a lot of baremetal deployments with assisted. There's not really any reason it can't be used on all platforms either.

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cybertron]

/jira refresh

[openshift-ci-robot]

@cybertron: This pull request references Jira Issue OCPBUGS-48566, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mkowalski]

/lgtm

[rbbratta]

/lgtm

[openshift-ci]

@cybertron: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-upgrade-out-of-change	2f4e055	link	false	/test e2e-aws-ovn-upgrade-out-of-change
ci/prow/e2e-azure-ovn-upgrade-out-of-change	2f4e055	link	false	/test e2e-azure-ovn-upgrade-out-of-change
ci/prow/okd-scos-e2e-aws-ovn	2f4e055	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-op-ocl	2f4e055	link	false	/test e2e-gcp-op-ocl
ci/prow/e2e-gcp-op-techpreview	2f4e055	link	false	/test e2e-gcp-op-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[cybertron]

/retest-required

This should be a noop in any of the failing jobs, and the failures don't appear to be related to the change anyway.

[cybertron]

/label acknowledge-critical-fixes-only
/assign @yuqi-zhang

This is needed for some very high priority work, so I think we're justified in merging it now.

[yuqi-zhang]

the template change is fine with me, I'm wondering how this affects other platforms, if at all?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, mkowalski, rbbratta, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@cybertron: Jira Issue OCPBUGS-48566: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#4795

Jira Issue OCPBUGS-48566 has been moved to the MODIFIED state.

In response to this:

While we don't necessarily expect this to be used everywhere yet, we at least need to have it on platform None since that is used for a lot of baremetal deployments with assisted. There's not really any reason it can't be used on all platforms either.

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.19.0-202501220640.p0.g6fef6ad.assembly.stream.el9.
All builds following this will include this PR.

[cybertron]

the template change is fine with me, I'm wondering how this affects other platforms, if at all?

Unless you provide the additional configurations that are consumed by this service, it's a noop. We initially enabled this only on baremetal because that's where we expected to use it, but it has recently come to our attention that it's unusable on baremetal deployed with assisted installer because they use platform None. It's been in for a few releases without causing any problems on baremetal, so it should be safe to enable everywhere.

[cybertron]

/cherrypick release-4.18

[openshift-cherrypick-robot]

@cybertron: new pull request created: #4804

In response to this:

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.