Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add support for Drop-in config dir in OCP #4779

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sohankunkerkar
Copy link
Member

- What I did

- How to verify it

- Description for the changelog

@sohankunkerkar sohankunkerkar marked this pull request as draft January 8, 2025 16:53
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2025
@openshift-ci openshift-ci bot requested review from djoshy and umohnani8 January 8, 2025 16:55
Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sohankunkerkar
Once this PR has been reviewed and has the lgtm label, please assign yuqi-zhang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

@sohankunkerkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 8cc06a9 link true /test verify
ci/prow/e2e-gcp-op 8cc06a9 link true /test e2e-gcp-op
ci/prow/e2e-gcp-op-ocl 8cc06a9 link false /test e2e-gcp-op-ocl
ci/prow/e2e-vsphere-ovn-zones 8cc06a9 link false /test e2e-vsphere-ovn-zones
ci/prow/e2e-hypershift 8cc06a9 link true /test e2e-hypershift
ci/prow/e2e-aws-ovn-upgrade 8cc06a9 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-agent-compact-ipv4 8cc06a9 link false /test e2e-agent-compact-ipv4
ci/prow/unit 8cc06a9 link true /test unit
ci/prow/e2e-aws-ovn-upgrade-out-of-change 8cc06a9 link false /test e2e-aws-ovn-upgrade-out-of-change
ci/prow/e2e-aws-ovn 8cc06a9 link true /test e2e-aws-ovn
ci/prow/e2e-vsphere-ovn-upi 8cc06a9 link false /test e2e-vsphere-ovn-upi
ci/prow/e2e-gcp-op-techpreview 8cc06a9 link false /test e2e-gcp-op-techpreview
ci/prow/bootstrap-unit 8cc06a9 link false /test bootstrap-unit
ci/prow/images 8cc06a9 link true /test images
ci/prow/okd-scos-e2e-aws-ovn 8cc06a9 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-ovn-upi-zones 8cc06a9 link false /test e2e-vsphere-ovn-upi-zones
ci/prow/e2e-azure-ovn-upgrade-out-of-change 8cc06a9 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-single-node 8cc06a9 link true /test e2e-gcp-op-single-node
ci/prow/e2e-openstack 8cc06a9 link false /test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sohankunkerkar sohankunkerkar force-pushed the fix-kubelet-config branch 3 times, most recently from 660ffc7 to d88b4d6 Compare January 9, 2025 22:21
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants