Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: sync /etc/containers/storage.conf #3283

Closed
wants to merge 1 commit into from

Conversation

haircommander
Copy link
Member

in particular, add nodev,metacopy=on to the overlay mountopts

Signed-off-by: Peter Hunt [email protected]

- What I did

- How to verify it

- Description for the changelog

in particular, add `nodev,metacopy=on` to the overlay mountopts

Signed-off-by: Peter Hunt~ <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haircommander
Once this PR has been reviewed and has the lgtm label, please assign cheesesashimi for approval by writing /assign @cheesesashimi in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haircommander
Copy link
Member Author

/hold

I need to verify those are the values we want

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2022
@haircommander
Copy link
Member Author

containers/storage#208

apparently, not having nodev is intentional, though the file does not make that clear

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2022

@haircommander: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws bb6f514 link true /test e2e-aws
ci/prow/e2e-agnostic-upgrade bb6f514 link true /test e2e-agnostic-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member Author

I don't think we want this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant