-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump test e2e timeout to 100m #3039
Conversation
e2e-gcp-op has been failing on a lot of PRs, and while continuing to increase the timeout long term is not the solution, it seems like bumping the timeout for now is better than mashing retest until we fix it
Why is the test timing out? Is this a functional issue or were other tests added? If the latter there might be a bug. When did this start? |
Not sure. At least as early as #2976 (comment) |
I think we're more interested in when it first started - was it a PR or did something else change? |
@mkenigs: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I agree it'd be good to investigate, but I think merging this PR as is is better than the status quo of wasting CI resources on retesting until PRs eventually make it in. |
/approve This PR was 85.6 minutes for reference. But yeah, looking at e.g. this job from the release-4.10 branch the run as at 78 minutes. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, mkenigs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Just eyeballing it, some differences: 4.11: 4.11: Computing how much variance there is here and digging into why is another task... |
gcp-op is mainly green so it's not really blocking merges. We have before just extended test times and later on realized there was indeed a bug. Since this isn't blocking prs from merging (other jobs are doing that) would prefer to know when this started and root cause instead of just extending time. Those times Colin points out above are very very not trivial. =/ |
This is a repeat of openshift#3039
This is a repeat of openshift#3039
e2e-gcp-op has been failing on a lot of PRs, and while continuing to
increase the timeout long term is not the solution, it seems like
bumping the timeout for now is better than mashing retest until we fix
it