Bug 1797647: [release-4.3] [baremetal] Ipv6 non virtual ip fix #1466
Conversation
In IPv6 DHCPv6 environments, the prefix for the IPv6 address that we must use to bind services may be 128. In case that happens, the current detection code will fail to consider the address as being in the right subnet. Thankfully, thanks to the Route Advertisements, we get the prefix information we need from the routing table. This patch adds the extra code to generate pseudo CIDRs that allow us to check if an address is in the right subnet. Signed-off-by: Antoni Segura Puimedon <[email protected]>
This patch simplifies filtering by: * Calling iface_cidrs only once, * Filtering out IPv6 addresses marked with the *deprecated* flag * Allowing multiple filters Signed-off-by: Antoni Segura Puimedon <[email protected]>
This change prevents: * Kubelet choosing as node IP an address from a non control plane subnet (like the provisioning network) * Kubelet choosing a deprecated IPv6 address as its node IP that in several platform can be a VIP Signed-off-by: Antoni Segura Puimedon <[email protected]>
CRI-O on startup could get addresses with expiring leases or from interfaces that are in isolated networks. This patch extends kubelet-nodeip.service to fix CRI-O as well. Signed-off-by: Antoni Segura Puimedon <[email protected]>
|
@russellb: This pull request references Bugzilla bug 1797647, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
openshift-ci-robot
added
the
size/XL
|
/retest |
openshift-ci-robot
added
the
approved
|
/test e2e-gcp-upgrade |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celebdor, kikisdeliveryservice, russellb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
mfojtik
added
the
cherry-pick-approved
|
/bugzilla refresh |
This is a 4.3 backport of PRs #1436 and #1444