Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcc: replace cttypes with ign v3 types #565

Closed
kikisdeliveryservice opened this issue Mar 20, 2019 · 4 comments
Closed

mcc: replace cttypes with ign v3 types #565

kikisdeliveryservice opened this issue Mar 20, 2019 · 4 comments
Assignees
@kikisdeliveryservice
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Mar 20, 2019 •
edited
Loading

Just making this for future change:
Once ign v3_0 is release replace cttypes in transpiling to ign functions (ssh, files, systemd units in render.go) with http://github.com/coreos/ignition/config/v3_0/types - to be created.

cc: @runcom @ajeddeloh
@kikisdeliveryservice kikisdeliveryservice changed the title [ign 3_0] mcc: replace cttypes with ign v3 types [draft] mcc: replace cttypes with ign v3 types Mar 20, 2019
@runcom runcom added the jira label Mar 20, 2019
Closed
@kikisdeliveryservice kikisdeliveryservice changed the title [draft] mcc: replace cttypes with ign v3 types mcc: replace cttypes with ign v3 types Mar 28, 2019
@kikisdeliveryservice
Copy link
Contributor Author

this is being addressed by #583
/assign

kikisdeliveryservice added a commit to kikisdeliveryservice/machine-config-operator that referenced this issue Mar 29, 2019
@kikisdeliveryservice
Ignition v2 to v3 transition
2fcadf8 
Updating MC* to use ignition v3. The following changes are included:
- ssh keys now written to /home/core/.ssh/authorized_keys.d/ignition
- code changes to use v3 and remove usage of v2.2.0
- unit and e2e test updates
- updated golden files
- remove the use of container-linux-config-transpiler in render.go and
  use v3 types instead

Requires: openshift/installer#1468
Closes: openshift#565
@dustymabe dustymabe removed the jira label Sep 5, 2019
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2020
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 17, 2020
@kikisdeliveryservice
Copy link
Contributor Author

closing as we've done the 2->3 transition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kikisdeliveryservice kikisdeliveryservice

Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] * : Ignition v2 to v3 transition kikisdeliveryservice/machine-config-operator
5 participants
@runcom @openshift-bot @dustymabe @kikisdeliveryservice @openshift-ci-robot