Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix issues #9

Merged
merged 2 commits into from
Dec 6, 2021
Merged

ci: fix issues #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3580f40
ci: fix typos flagged by ci
nbalacha Dec 6, 2021
21dc7e3
ci: fix yamllint errors
nbalacha Dec 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/v1alpha1/lvmcluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ type DeviceClass struct {
// Config *DeviceClassConfig `json:"config,omitempty"`
}

// DeviceSelector allows specifiying a list of criteria that have to match before a device is assigned
// DeviceSelector specifies the list of criteria that have to match before a device is assigned
type DeviceSelector struct {
// MinSize is the minimum size of the device which needs to be included. Defaults to `1Gi` if empty
// +optional
Expand Down
2 changes: 1 addition & 1 deletion config/samples/lvm_v1alpha1_lvmcluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: lvm.topolvm.io/v1alpha1
kind: LVMCluster
metadata:
name: lvmcluster-sample
spec:
spec:
deviceClasses:
- name: vg1
- deviceSelector:
4 changes: 2 additions & 2 deletions doc/design/operator.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@


Each unit of reconciliation should implement the reconcileUnit interface.
This will be run by the controller, and errors and success will be propogated to the status and events.
This will be run by the controller, and errors and success will be propagated to the status and events.
This interface is defined in [lvmcluster_controller.go](../../controllers/lvmcluster_controller.go)

```
Expand All @@ -38,4 +38,4 @@ type resourceManager interface {
// status that changes only when the operands change.
updateStatus(*LVMClusterReconciler, context.Context, lvmv1alpha1.LVMCluster) error
}
```
```