OCPBUGS-41632: fix: ensure uniq available devices

[jakobmoellerdev]

Ensure that for device mapper devices that are exposed under multiple children, we report the device at most once. Otherwise we can have multiple available devices that will error out in the vgcreate process. An example is an mdadm raid array, so I added a test case to confirm this.

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-41632, which is invalid:

• expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.17.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Ensure that for device mapper devices that are exposed under multiple children, we report the device at most once. Otherwise we can have multiple available devices that will error out in the vgcreate process. An example is an mdadm raid array, so I added a test case to confirm this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jakobmoellerdev]

/jira refresh

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-41632, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mmakwana30

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jakobmoellerdev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[suleymanakbas91]

/lgtm

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.93%. Comparing base (9946603) to head (63db74d).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
+ Coverage   69.30%   71.93%   +2.63%     
==========================================
  Files          49       49              
  Lines        3313     3560     +247     
==========================================
+ Hits         2296     2561     +265     
+ Misses        841      831      -10     
+ Partials      176      168       -8     

Files with missing lines	Coverage Δ
internal/controllers/vgmanager/devices.go	81.00% <100.00%> (+1.65%)	⬆️

... and 8 files with indirect coverage changes

[jakobmoellerdev]

/retest-required

[openshift-ci]

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jakobmoellerdev: Jira Issue OCPBUGS-41632: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#712

Jira Issue OCPBUGS-41632 has been moved to the MODIFIED state.

In response to this:

Ensure that for device mapper devices that are exposed under multiple children, we report the device at most once. Otherwise we can have multiple available devices that will error out in the vgcreate process. An example is an mdadm raid array, so I added a test case to confirm this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jakobmoellerdev]

/cherry-pick release-4.17

[openshift-cherrypick-robot]

@jakobmoellerdev: new pull request created: #714

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.