OCPBUGS-37844: fix: resource sync fail -> progressing

[jakobmoellerdev]

When the resource syncrhonization fails (e.g. because of an irrepairable error due to cluster state or due to the CSI node not being synchronized) we should move the status to progressing. That is because all of the resource sync problems are either resolvable automatically (after a certain time), or can be remediated by the user through changes in the cluster.

There is an edge that if we configure the pods wrong in the reconcile, then we have a permanent failure with state Progressing. However this is still technically correct since the Reconciler will keep trying to apply the resources (as opposed to perceived Failed which users would expect to not conclude with a retry)

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-37844, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When the resource syncrhonization fails (e.g. because of an irrepairable error due to cluster state or due to the CSI node not being synchronized) we should move the status to progressing. That is because all of the resource sync problems are either resolvable automatically (after a certain time), or can be remediated by the user through changes in the cluster.

There is an edge that if we configure the pods wrong in the reconcile, then we have a permanent failure with state Progressing. However this is still technically correct since the Reconciler will keep trying to apply the resources (as opposed to perceived Failed which users would expect to not conclude with a retry)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jakobmoellerdev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.04%. Comparing base (1357036) to head (93b32b0).

Files	Patch %	Lines
internal/controllers/lvmcluster/status.go	40.00%	3 Missing ⚠️
internal/controllers/lvmcluster/controller.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
- Coverage   70.66%   70.04%   -0.62%     
==========================================
  Files          47       47              
  Lines        3245     3245              
==========================================
- Hits         2293     2273      -20     
- Misses        785      800      +15     
- Partials      167      172       +5     

Files	Coverage Δ
internal/controllers/lvmcluster/controller.go	62.33% <0.00%> (-7.80%)	⬇️
internal/controllers/lvmcluster/status.go	88.88% <40.00%> (-4.10%)	⬇️

... and 3 files with indirect coverage changes

[suleymanakbas91]

/lgtm

[openshift-ci]

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jakobmoellerdev: Jira Issue OCPBUGS-37844: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#688

Jira Issue OCPBUGS-37844 has been moved to the MODIFIED state.

In response to this:

When the resource syncrhonization fails (e.g. because of an irrepairable error due to cluster state or due to the CSI node not being synchronized) we should move the status to progressing. That is because all of the resource sync problems are either resolvable automatically (after a certain time), or can be remediated by the user through changes in the cluster.

There is an edge that if we configure the pods wrong in the reconcile, then we have a permanent failure with state Progressing. However this is still technically correct since the Reconciler will keep trying to apply the resources (as opposed to perceived Failed which users would expect to not conclude with a retry)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.