Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adds operator-sdk make target #65

Merged
merged 1 commit into from
Jan 10, 2022
Merged

fix: adds operator-sdk make target #65

merged 1 commit into from
Jan 10, 2022

Conversation

nbalacha
Copy link
Contributor

@nbalacha nbalacha commented Jan 9, 2022

Adds a make target to download the operator-sdk binary.
This is required for downstream builds.

Signed-off-by: N Balachandran [email protected]

@nbalacha
fix: adds operator-sdk make target
2cd745b 
Adds a make target to download the operator-sdk binary.
This is required for downstream builds.

Signed-off-by: N Balachandran <[email protected]>
@nbalacha
Copy link
Contributor Author

nbalacha commented Jan 9, 2022

I have currently just copied and modified the opm target. Todo : Write a function to do this.

leelavg
leelavg approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 10, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg, nbalacha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leelavg
Copy link
Contributor

leelavg commented Jan 10, 2022

I have currently just copied and modified the opm target. Todo : Write a function to do this.

by writing a function you mean, factor out installation in opm & operator-sdk?

@nbalacha
Copy link
Contributor Author

I have currently just copied and modified the opm target. Todo : Write a function to do this.

by writing a function you mean, factor out installation in opm & operator-sdk?

Yes, that's right.

@nbalacha nbalacha merged commit 01d6f20 into main Jan 10, 2022
@nbalacha nbalacha deleted the makefile branch January 10, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leelavg leelavg leelavg approved these changes

Assignees

@leelavg leelavg

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbalacha @leelavg