-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPEDGE-549: Remove temporary tagging logic #648
OCPEDGE-549: Remove temporary tagging logic #648
Conversation
@suleymanakbas91: This pull request references OCPEDGE-549 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #648 +/- ##
==========================================
- Coverage 58.33% 57.96% -0.38%
==========================================
Files 54 53 -1
Lines 4258 4199 -59
==========================================
- Hits 2484 2434 -50
+ Misses 1525 1524 -1
+ Partials 249 241 -8
|
/retest |
Signed-off-by: Suleyman Akbas <[email protected]>
7de53c5
to
0abb0ce
Compare
/retest |
@suleymanakbas91: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR removes the temporary tagging logic we introduced in 4.15 to make upgrades from 4.14 to 4.15 seamless. This is no longer needed in 4.17 or later releases.