Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPEDGE-549: Remove temporary tagging logic #648

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

suleymanakbas91
Copy link
Contributor

This PR removes the temporary tagging logic we introduced in 4.15 to make upgrades from 4.14 to 4.15 seamless. This is no longer needed in 4.17 or later releases.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 26, 2024

@suleymanakbas91: This pull request references OCPEDGE-549 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

This PR removes the temporary tagging logic we introduced in 4.15 to make upgrades from 4.14 to 4.15 seamless. This is no longer needed in 4.17 or later releases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 26, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.96%. Comparing base (748fb1b) to head (0abb0ce).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
- Coverage   58.33%   57.96%   -0.38%     
==========================================
  Files          54       53       -1     
  Lines        4258     4199      -59     
==========================================
- Hits         2484     2434      -50     
+ Misses       1525     1524       -1     
+ Partials      249      241       -8     
Files Coverage Δ
cmd/vgmanager/vgmanager.go 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

@suleymanakbas91
Copy link
Contributor Author

/retest

@suleymanakbas91
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Jun 26, 2024

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
Copy link
Contributor

openshift-ci bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jakobmoellerdev,suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1123d37 into openshift:main Jun 27, 2024
9 checks passed
@suleymanakbas91 suleymanakbas91 deleted the rem-tagging branch June 27, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants