Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removes VGMANAGER_IMAGE from the configmap #64

Merged
merged 1 commit into from
Jan 6, 2022
Merged

fix: removes VGMANAGER_IMAGE from the configmap #64

merged 1 commit into from
Jan 6, 2022

Conversation

nbalacha
Copy link
Contributor

@nbalacha nbalacha commented Jan 6, 2022

Remove the VGMANAGER_IMAGE env variable from the manager
configmap. The default behaviour will be to use the same image
for both the controller and the vgmanager.

Signed-off-by: N Balachandran [email protected]

Remove the VGMANAGER_IMAGE env variable from the manager
configmap. The default behaviour will be to use the same image
for both the controller and the vgmanager.

Signed-off-by: N Balachandran <[email protected]>
Copy link
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg, nbalacha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nbalacha nbalacha merged commit 843a893 into openshift:main Jan 6, 2022
@nbalacha nbalacha deleted the vg_image branch January 6, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants