OCPBUGS-35817: LVMCluster now reports In Progress if it could not create any VGs yet

[suleymanakbas91]

No description provided.

[openshift-ci-robot]

@suleymanakbas91: This pull request references Jira Issue OCPBUGS-35817, which is invalid:

• expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[suleymanakbas91]

/jira refresh

[openshift-ci-robot]

@suleymanakbas91: This pull request references Jira Issue OCPBUGS-35817, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[suleymanakbas91]

/hold

[jakobmoellerdev]

have to go for a second round on the test cases but mostly LGTM

[suleymanakbas91]

/retest

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 89.53488% with 9 lines in your changes missing coverage. Please review.

Project coverage is 58.94%. Comparing base (b0c38da) to head (133d8e1).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   58.00%   58.94%   +0.93%     
==========================================
  Files          54       54              
  Lines        4117     4160      +43     
==========================================
+ Hits         2388     2452      +64     
+ Misses       1492     1468      -24     
- Partials      237      240       +3     

Files	Coverage Δ
internal/controllers/lvmcluster/controller.go	61.84% <66.66%> (-0.33%)	⬇️
...ternal/controllers/lvmcluster/selector/selector.go	27.58% <0.00%> (ø)
internal/controllers/lvmcluster/status.go	88.88% <93.58%> (+20.70%)	⬆️

[openshift-ci]

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jakobmoellerdev]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jakobmoellerdev,suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@suleymanakbas91: Jira Issue OCPBUGS-35817: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#636

Jira Issue OCPBUGS-35817 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.