Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPEDGE-1151: chore: k8s 1.30 / go1.22 #634

Merged
merged 8 commits into from
Jul 3, 2024

Conversation

jakobmoellerdev
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev commented Jun 13, 2024

Notable issues this rebase:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2024
Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jakobmoellerdev
Copy link
Contributor Author

/test all

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 13, 2024
Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2024
@jakobmoellerdev
Copy link
Contributor Author

/test all

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 58.00%. Comparing base (bf9fc3a) to head (6fbd95e).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
+ Coverage   57.95%   58.00%   +0.05%     
==========================================
  Files          53       53              
  Lines        4212     4215       +3     
==========================================
+ Hits         2441     2445       +4     
- Misses       1529     1530       +1     
+ Partials      242      240       -2     
Files Coverage Δ
cmd/vgmanager/vgmanager.go 0.00% <ø> (ø)
...ernal/controllers/lvmcluster/controller_watches.go 75.32% <ø> (ø)
...llers/lvmcluster/resource/topolvm_snapshotclass.go 80.43% <ø> (ø)
...ontrollers/vgmanager/dmsetup/mocks/mock_dmsetup.go 56.66% <ø> (ø)
...al/controllers/vgmanager/lsblk/mocks/mock_lsblk.go 33.33% <ø> (ø)
...ternal/controllers/vgmanager/lvm/mocks/mock_lvm.go 33.24% <ø> (ø)
...trollers/vgmanager/lvmd/mocks/mock_configurator.go 28.57% <ø> (ø)
.../controllers/vgmanager/wipefs/mocks/mock_wipefs.go 56.66% <ø> (ø)
cmd/operator/operator.go 0.00% <0.00%> (ø)
internal/csi/resizer.go 0.00% <0.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

@jakobmoellerdev jakobmoellerdev changed the title chore: k8s 1.30 chore: k8s 1.30 / go1.22 Jun 13, 2024
@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

@jakobmoellerdev jakobmoellerdev changed the title chore: k8s 1.30 / go1.22 OCPEDGE-1151: chore: k8s 1.30 / go1.22 Jun 24, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 24, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 24, 2024

@jakobmoellerdev: This pull request references OCPEDGE-1151 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2024
Signed-off-by: Jakob Möller <[email protected]>
Signed-off-by: Jakob Möller <[email protected]>
Signed-off-by: Jakob Möller <[email protected]>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2024
@jakobmoellerdev
Copy link
Contributor Author

/test all

@jakobmoellerdev
Copy link
Contributor Author

/test unit-test

@jakobmoellerdev
Copy link
Contributor Author

/test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 2, 2024

@jakobmoellerdev: This pull request references OCPEDGE-1151 which is a valid jira issue.

In response to this:

Notable issues this rebase:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Signed-off-by: Jakob Möller <[email protected]>
@jakobmoellerdev
Copy link
Contributor Author

/test all

Signed-off-by: Jakob Möller <[email protected]>
@jakobmoellerdev
Copy link
Contributor Author

/test all

@jakobmoellerdev
Copy link
Contributor Author

/retest

@jakobmoellerdev
Copy link
Contributor Author

/test precommit-check

@jakobmoellerdev
Copy link
Contributor Author

/test images

1 similar comment
@jakobmoellerdev
Copy link
Contributor Author

/test images

@jakobmoellerdev
Copy link
Contributor Author

/test precommit-check

@jakobmoellerdev
Copy link
Contributor Author

/retest

Signed-off-by: Jakob Möller <[email protected]>
Signed-off-by: Jakob Möller <[email protected]>
@jakobmoellerdev
Copy link
Contributor Author

/test all

@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review July 3, 2024 09:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2024
Copy link
Contributor

openshift-ci bot commented Jul 3, 2024

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7d3ceed into openshift:main Jul 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants