OCPBUGS-30830: Accommodate the case in readiness calculation where readyVGCount is greater than expectedVGCount

[suleymanakbas91]

This PR updates the readiness calculation logic to accommodate the case where readyVGCount is greater than expectedVGCount, e.g. during an upgrade.

[openshift-ci-robot]

@suleymanakbas91: This pull request references Jira Issue OCPBUGS-30830, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR updates the readiness calculation logic to accommodate the case where readyVGCount is greater than expectedVGCount, e.g. during an upgrade.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[suleymanakbas91]

/jira refresh

[openshift-ci-robot]

@suleymanakbas91: This pull request references Jira Issue OCPBUGS-30830, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.56%. Comparing base (7a7d364) to head (33c158b).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
- Coverage   77.66%   77.56%   -0.11%     
==========================================
  Files          27       27              
  Lines        1952     1952              
==========================================
- Hits         1516     1514       -2     
- Misses        319      320       +1     
- Partials      117      118       +1     

Files	Coverage Δ
internal/controllers/lvmcluster/controller.go	64.21% <0.00%> (-0.99%)	⬇️

[jakobmoellerdev]

/test snyk-deps

[openshift-ci]

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jakobmoellerdev]

As I understand we are still missing one part here from the original triage:

Additionally, because we dont watch for Node Taints on LVMCluster, the reconcile loop is not refreshed which means one has to either restart lvm-operator or wait until the cache resets (2 hours).

Do we already get the node updates?

[jakobmoellerdev]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jakobmoellerdev,suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@suleymanakbas91: Jira Issue OCPBUGS-30830: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#612

Jira Issue OCPBUGS-30830 has been moved to the MODIFIED state.

In response to this:

This PR updates the readiness calculation logic to accommodate the case where readyVGCount is greater than expectedVGCount, e.g. during an upgrade.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[suleymanakbas91]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@suleymanakbas91: new pull request created: #613

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.