Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-768: chore: bind openshift/topolvm in go.mod and update other deps #475

Merged

Conversation

jakobmoellerdev
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@jakobmoellerdev
Copy link
Contributor Author

/test all

Copy link
Contributor

openshift-ci bot commented Nov 3, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 3, 2023
Copy link
Contributor

openshift-ci bot commented Nov 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2023
@jakobmoellerdev jakobmoellerdev force-pushed the openshift-topolvm-in-gomod branch from 5bb3726 to fb98a87 Compare November 3, 2023 11:38
@jakobmoellerdev
Copy link
Contributor Author

/test all

@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review November 3, 2023 11:43
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #475 (fb98a87) into main (425a60b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   82.03%   82.03%           
=======================================
  Files          24       24           
  Lines        1781     1781           
=======================================
  Hits         1461     1461           
  Misses        219      219           
  Partials      101      101           

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2023
@jakobmoellerdev jakobmoellerdev changed the title chore: bind openshift/topolvm in go.mod and update other deps OCPVE-768: chore: bind openshift/topolvm in go.mod and update other deps Nov 3, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 3, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 3, 2023

@jakobmoellerdev: This pull request references OCPVE-768 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 19a3b4e and 2 for PR HEAD fb98a87 in total

Copy link
Contributor

openshift-ci bot commented Nov 3, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit a877f70 into openshift:main Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants