Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-747: fix: vgmanager thin pool and controller tests and smaller fixes #460

Merged

Conversation

jakobmoellerdev
Copy link
Contributor

Introduces Edge Case Unit Tests for various parts of thin pool management in vgmanager that have a lot of branch complexity. Also fixes smaller issues in the controllers discovered during these branch tests

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 23, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 23, 2023

@jakobmoellerdev: This pull request references OCPVE-747 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Introduces Edge Case Unit Tests for various parts of thin pool management in vgmanager that have a lot of branch complexity. Also fixes smaller issues in the controllers discovered during these branch tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #460 (cbce86a) into main (cbe8778) will increase coverage by 14.51%.
Report is 2 commits behind head on main.
The diff coverage is 97.56%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #460       +/-   ##
===========================================
+ Coverage   56.91%   71.42%   +14.51%     
===========================================
  Files          22       22               
  Lines        1736     1806       +70     
===========================================
+ Hits          988     1290      +302     
+ Misses        626      404      -222     
+ Partials      122      112       -10     
Files Coverage Δ
internal/controllers/vgmanager/lvm/lvm.go 88.36% <ø> (+48.03%) ⬆️
internal/controllers/vgmanager/controller.go 69.75% <97.56%> (+34.12%) ⬆️

... and 2 files with indirect coverage changes

@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 095cb9a into openshift:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants