-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPVE-747: fix: vgmanager thin pool and controller tests and smaller fixes #460
OCPVE-747: fix: vgmanager thin pool and controller tests and smaller fixes #460
Conversation
Signed-off-by: Jakob Möller <[email protected]>
@jakobmoellerdev: This pull request references OCPVE-747 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
===========================================
+ Coverage 56.91% 71.42% +14.51%
===========================================
Files 22 22
Lines 1736 1806 +70
===========================================
+ Hits 988 1290 +302
+ Misses 626 404 -222
+ Partials 122 112 -10
|
/lgtm |
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Introduces Edge Case Unit Tests for various parts of thin pool management in vgmanager that have a lot of branch complexity. Also fixes smaller issues in the controllers discovered during these branch tests