Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-726: Activate inactive logical volumes #446

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

suleymanakbas91
Copy link
Contributor

This PR adds a logic to activate the inactive logical volumes. This is important for the recovery scenario where the leftover logical volumes from a previous installation can be inactive and need to be activated to be used in LVMS.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 10, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2023

@suleymanakbas91: This pull request references OCPVE-726 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This PR adds a logic to activate the inactive logical volumes. This is important for the recovery scenario where the leftover logical volumes from a previous installation can be inactive and need to be activated to be used in LVMS.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 10, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #446 (418c711) into main (2d2c100) will decrease coverage by 0.17%.
Report is 2 commits behind head on main.
The diff coverage is 40.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
- Coverage   59.41%   59.24%   -0.17%     
==========================================
  Files          21       21              
  Lines        1614     1622       +8     
==========================================
+ Hits          959      961       +2     
- Misses        539      545       +6     
  Partials      116      116              
Files Coverage Δ
internal/controllers/vgmanager/controller.go 34.60% <100.00%> (+0.38%) ⬆️
internal/controllers/vgmanager/lvm/lvm.go 42.19% <0.00%> (-1.52%) ⬇️

@suleymanakbas91
Copy link
Contributor Author

/retest

Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

nice change :)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@jakobmoellerdev
Copy link
Contributor

/retest-required

@suleymanakbas91
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jakobmoellerdev,suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 441ca07 and 2 for PR HEAD 418c711 in total

@suleymanakbas91
Copy link
Contributor Author

/retest

4 similar comments
@suleymanakbas91
Copy link
Contributor Author

/retest

@suleymanakbas91
Copy link
Contributor Author

/retest

@suleymanakbas91
Copy link
Contributor Author

/retest

@suleymanakbas91
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 63c12a5 and 1 for PR HEAD 418c711 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jakobmoellerdev
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci openshift-ci bot merged commit 61e044a into openshift:main Oct 10, 2023
@suleymanakbas91 suleymanakbas91 deleted the activate branch October 11, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants