Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-669: chore: refactor e2e tests #424

Merged

Conversation

jakobmoellerdev
Copy link
Contributor

Refactors the E2E tests to use in-code generation of resources and removes all of the test data. Also fixes the cleanup issue where resources sometimes got stuck in the E2E test and the deletion timeout didn't work.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 14, 2023

@jakobmoellerdev: This pull request references OCPVE-669 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Refactors the E2E tests to use in-code generation of resources and removes all of the test data. Also fixes the cleanup issue where resources sometimes got stuck in the E2E test and the deletion timeout didn't work.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 14, 2023
@jakobmoellerdev
Copy link
Contributor Author

/test all

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Merging #424 (ade2b73) into main (1068f03) will not change coverage.
Report is 5 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #424   +/-   ##
=======================================
  Coverage   62.26%   62.26%           
=======================================
  Files          27       27           
  Lines        2335     2335           
=======================================
  Hits         1454     1454           
  Misses        749      749           
  Partials      132      132           
Files Changed Coverage Δ
controllers/lvmcluster_controller.go 61.73% <0.00%> (ø)

@jakobmoellerdev
Copy link
Contributor Author

/test all

@jakobmoellerdev
Copy link
Contributor Author

/test all

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review September 15, 2023 07:11
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2023
@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-669-test-refactor branch 2 times, most recently from ca7e297 to ade2b73 Compare September 15, 2023 08:29
@jakobmoellerdev
Copy link
Contributor Author

verify failing because of openshift/release#43223

@jakobmoellerdev
Copy link
Contributor Author

/test lvms-pre-commit

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2023

@jakobmoellerdev: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test ci-index-lvm-operator-bundle
  • /test images
  • /test lvm-operator-e2e-aws
  • /test lvm-operator-e2e-aws-sno
  • /test precommit-check
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/test lvms-pre-commit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev
Copy link
Contributor Author

/test precommit-check

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

@jakobmoellerdev
Copy link
Contributor Author

/override verify

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

@jakobmoellerdev: jakobmoellerdev unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight.

In response to this:

/override verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@suleymanakbas91
Copy link
Contributor

/override verify

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

@suleymanakbas91: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • verify

Only the following failed contexts/checkruns were expected:

  • ci/prow/ci-index-lvm-operator-bundle
  • ci/prow/images
  • ci/prow/lvm-operator-e2e-aws
  • ci/prow/lvm-operator-e2e-aws-sno
  • ci/prow/precommit-check
  • ci/prow/unit-test
  • ci/prow/verify
  • pull-ci-openshift-lvm-operator-main-ci-index-lvm-operator-bundle
  • pull-ci-openshift-lvm-operator-main-images
  • pull-ci-openshift-lvm-operator-main-lvm-operator-e2e-aws
  • pull-ci-openshift-lvm-operator-main-lvm-operator-e2e-aws-sno
  • pull-ci-openshift-lvm-operator-main-precommit-check
  • pull-ci-openshift-lvm-operator-main-unit-test
  • pull-ci-openshift-lvm-operator-release-4.14-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@suleymanakbas91
Copy link
Contributor

/override ci/prow/verify

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

@suleymanakbas91: Overrode contexts on behalf of suleymanakbas91: ci/prow/verify

In response to this:

/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@suleymanakbas91 suleymanakbas91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just added one small comment.

test/e2e/helper_test.go Outdated Show resolved Hide resolved
@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-669-test-refactor branch 2 times, most recently from a2e74f1 to c0022d2 Compare September 19, 2023 10:56
@jakobmoellerdev
Copy link
Contributor Author

/retest-required

@jakobmoellerdev
Copy link
Contributor Author

/retest-required

@suleymanakbas91
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@jakobmoellerdev
Copy link
Contributor Author

/retest-required

2 similar comments
@jakobmoellerdev
Copy link
Contributor Author

/retest-required

@jakobmoellerdev
Copy link
Contributor Author

/retest-required

@suleymanakbas91
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7c4732b and 2 for PR HEAD b1efb6d in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f2d644a into openshift:main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants