-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPVE-669: chore: refactor e2e tests #424
OCPVE-669: chore: refactor e2e tests #424
Conversation
@jakobmoellerdev: This pull request references OCPVE-669 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Skipping CI for Draft Pull Request. |
/test all |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
=======================================
Coverage 62.26% 62.26%
=======================================
Files 27 27
Lines 2335 2335
=======================================
Hits 1454 1454
Misses 749 749
Partials 132 132
|
701d70b
to
e08137e
Compare
/test all |
e08137e
to
6ada878
Compare
/test all |
/test lvm-operator-e2e-aws-sno |
ca7e297
to
ade2b73
Compare
verify failing because of openshift/release#43223 |
/test lvms-pre-commit |
@jakobmoellerdev: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test precommit-check |
/test lvm-operator-e2e-aws-sno |
/override verify |
@jakobmoellerdev: jakobmoellerdev unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override verify |
@suleymanakbas91: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/verify |
@suleymanakbas91: Overrode contexts on behalf of suleymanakbas91: ci/prow/verify In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just added one small comment.
a2e74f1
to
c0022d2
Compare
c0022d2
to
b1efb6d
Compare
/retest-required |
/retest-required |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
2 similar comments
/retest-required |
/retest-required |
/retest |
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Refactors the E2E tests to use in-code generation of resources and removes all of the test data. Also fixes the cleanup issue where resources sometimes got stuck in the E2E test and the deletion timeout didn't work.