Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPVE-677: fix: vgmanager unit tests failure on Darwin due to symlinked Temp Dir #420

Merged
merged 1 commit into from
Sep 14, 2023
Merged

OCPVE-677: fix: vgmanager unit tests failure on Darwin due to symlinked Temp Dir #420

merged 1 commit into from
Sep 14, 2023

Conversation

jakobmoellerdev
Copy link
Contributor

No description provided.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2023
@jakobmoellerdev jakobmoellerdev changed the title fix: attempt race fix fix: attempt race fix in vgmanager unit tests Sep 12, 2023
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 12, 2023
@jakobmoellerdev
Copy link
Contributor Author

/test all

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 12, 2023
@jakobmoellerdev jakobmoellerdev force-pushed the attempt-race-fix branch 3 times, most recently from 0bc51e7 to 58f313f Compare September 13, 2023 10:46
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2023
@jakobmoellerdev jakobmoellerdev changed the title fix: attempt race fix in vgmanager unit tests fix: fix in vgmanager unit tests failure on Darwin due to symlinked Temp Dir Sep 13, 2023
@jakobmoellerdev jakobmoellerdev changed the title fix: fix in vgmanager unit tests failure on Darwin due to symlinked Temp Dir fix: vgmanager unit tests failure on Darwin due to symlinked Temp Dir Sep 13, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2023
@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review September 13, 2023 10:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2023
@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jakobmoellerdev jakobmoellerdev changed the title fix: vgmanager unit tests failure on Darwin due to symlinked Temp Dir OCPVE-677: fix: vgmanager unit tests failure on Darwin due to symlinked Temp Dir Sep 14, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 14, 2023 •
edited by openshift-ci bot
Loading

@jakobmoellerdev: This pull request references OCPVE-677 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@suleymanakbas91
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit f9da4df into openshift:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandisher brandisher Awaiting requested review from brandisher

@suleymanakbas91 suleymanakbas91 Awaiting requested review from suleymanakbas91

Assignees

@suleymanakbas91 suleymanakbas91

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakobmoellerdev @openshift-ci-robot @suleymanakbas91 @openshift-merge-robot